Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_kafka_source temporary marked with xfail #234

Open
3 tasks done
Akasurde opened this issue Aug 6, 2024 · 0 comments
Open
3 tasks done

Fix flaky test_kafka_source temporary marked with xfail #234

Akasurde opened this issue Aug 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Akasurde
Copy link
Member

Akasurde commented Aug 6, 2024

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that event-driven-ansible collection is open source software provided for free and that I might not receive a timely response.

Bug Summary

test_kafka_source is flaky since we rely on stdout output from subprocess of ansible-rulebook.

Disable this test till we found better way to wait and capture subprocess output.

Environment

# ansible-rulebook --version
1.1.0
  Executable location = /usr/local/bin/ansible-rulebook
  Drools_jpy version = 0.3.9
  Java home = /usr/lib/jvm/java-21-openjdk-21.0.4.0.7-1.el9.x86_64
  Java version = 21.0.4
  Python version = 3.12.1 (main, May  3 2024, 00:00:00) [GCC 11.4.1 20231218 (Red Hat 11.4.1-3)]

Steps to reproduce

pytest tests/integration/event_source_kafka/ -s -v

Actual results

Tests are flaky which causes integration tests to fail.

Expected results

Tests pass consistently.

Additional information

No response

@Akasurde Akasurde added the bug Something isn't working label Aug 6, 2024
@ssbarnea ssbarnea changed the title Disable flaky test_kafka_source Fix flaky test_kafka_source temporary marked with xfail Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant