From 151841213a3bac1fbf075823107b2f24c2ee081f Mon Sep 17 00:00:00 2001 From: James Tanner Date: Wed, 22 May 2024 13:01:49 -0400 Subject: [PATCH 1/2] Use a more recent version of ansible-core in testing. No-Issue Signed-off-by: James Tanner --- integration_requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/integration_requirements.txt b/integration_requirements.txt index dd1134fa1f..784039fc36 100644 --- a/integration_requirements.txt +++ b/integration_requirements.txt @@ -1,7 +1,7 @@ epdb requests # pulp requires compatibility with python 3.8 -ansible-core<2.13.0 +ansible-core<2.17.0 pytest orionutils openapi-spec-validator From 3c49f78707dd0cf185514fa5d54a2714adda8065 Mon Sep 17 00:00:00 2001 From: James Tanner Date: Wed, 22 May 2024 14:47:01 -0400 Subject: [PATCH 2/2] Core fixed their bug =) No-Issue Signed-off-by: James Tanner --- .../integration/community/test_role_import_exceptions.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/galaxy_ng/tests/integration/community/test_role_import_exceptions.py b/galaxy_ng/tests/integration/community/test_role_import_exceptions.py index a71203fe48..668c1d7f22 100644 --- a/galaxy_ng/tests/integration/community/test_role_import_exceptions.py +++ b/galaxy_ng/tests/integration/community/test_role_import_exceptions.py @@ -62,9 +62,8 @@ def test_role_import_exceptions(ansible_config): check_retcode=False ) - # core always exits zero... - # https://github.com/ansible/ansible/issues/82175 - assert import_pid.returncode == 0 + # should have exited non-zero ... + assert import_pid.returncode == 1 stdout = import_pid.stdout.decode('utf-8') assert 'Traceback (most recent call last):' in stdout