Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

word2phrase: AddWord2Vocab strcpy's full length of strings longer than MAX_STRING #33

Open
GoogleCodeExporter opened this issue Aug 10, 2015 · 1 comment
Open

word2phrase: AddWord2Vocab strcpy's full length of strings longer than MAX_STRING #33

GoogleCodeExporter opened this issue Aug 10, 2015 · 1 comment
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

The strcmp should be changed to strncmp.  This may be causing segmentation 
faults in some cases when the input contains words that are too long.

Original issue reported on code.google.com by [email protected] on 17 Jul 2015 at 11:12
@GoogleCodeExporter
Copy link
Author 

Also, in SortVocab() the free is indexed to vocab_size, not the element 
actually being freed.

Original comment by [email protected] on 17 Jul 2015 at 11:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter