Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications are no longer being marked as read on GitHub #15

Open
benthamite opened this issue Nov 28, 2023 · 2 comments
Open

notifications are no longer being marked as read on GitHub #15

benthamite opened this issue Nov 28, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@benthamite
Copy link

benthamite commented Nov 28, 2023

Unfortunately, after a notification is read with gh-notify, it won’t be marked as read on GitHub, as used to be the case. I'm unsure whether this is linked to the recent forge changes or is unrelated to that issue. I tentatively think the latter, since I noticed this particular problem a couple of weeks after the forge problems.

@anticomputer anticomputer self-assigned this Apr 11, 2024
@anticomputer
Copy link
Owner

Digging into this now, I noticed today also with the latest forge that a topic visit no longer marks things as read on the GitHub side.

@anticomputer
Copy link
Owner

So I'm seeing some beta endpoints being used for the unread/read marking on GitHub (/notifications/beta/mark and /notifications/beta/unmark). It looks like those SHOULD support bulk status changes through an array of topic IDs but not sure how/if we can leverage that clientside since it's undocumented. To that end I'm going to hold off on kludging together remote marking support for now. Presumably Forge is also in a similar posture, and ideally this gets implemented on the forge visit end once GitHub gets out of beta with the notification endpoints. I'll leave this open to track progress.

@anticomputer anticomputer added the enhancement New feature or request label Apr 11, 2024
@benthamite benthamite changed the title notifications are no longer being mark as read on GitHub notifications are no longer being marked as read on GitHub Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants