From a73fa6b21072dbc71a2c1abf09f559a0985e4e27 Mon Sep 17 00:00:00 2001 From: Antonin Bas Date: Thu, 26 Oct 2023 10:59:32 -0700 Subject: [PATCH] Stop deleting group entries on switch connection (#75) There is no reason to treat groups any differently from flows, meters, etc. Bump up version to v0.12.0. Signed-off-by: Antonin Bas --- VERSION | 2 +- ofctrl/fgraphSwitch.go | 9 --------- ofctrl/ofSwitch.go | 3 --- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/VERSION b/VERSION index fd2726c9..87a1cf59 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -v0.11.0 +v0.12.0 diff --git a/ofctrl/fgraphSwitch.go b/ofctrl/fgraphSwitch.go index 88efcd56..279751dd 100644 --- a/ofctrl/fgraphSwitch.go +++ b/ofctrl/fgraphSwitch.go @@ -217,12 +217,3 @@ func (self *OFSwitch) NewFlood() (*Flood, error) { return flood, nil } - -// clearGroups clears all existing groups. -func (self *OFSwitch) clearGroups() error { - groupMod := openflow15.NewGroupMod() - groupMod.GroupId = openflow15.OFPG_ALL - groupMod.Command = openflow15.OFPGC_DELETE - groupMod.Type = openflow15.GT_ALL - return self.Send(groupMod) -} diff --git a/ofctrl/ofSwitch.go b/ofctrl/ofSwitch.go index 4da4a0d9..a458232a 100755 --- a/ofctrl/ofSwitch.go +++ b/ofctrl/ofSwitch.go @@ -158,9 +158,6 @@ func (self *OFSwitch) IsReady() bool { // Handle switch connected event func (self *OFSwitch) switchConnected() error { - if err := self.clearGroups(); err != nil { - return fmt.Errorf("fails to clear groups: %v", err) - } // Main receive loop for the switch go self.receive() // Periodically sends echo request message on the connection.