fix: filter out empty string ids in the legend data

antvis · Feb 20, 2025 · c45bb32 · c45bb32
1 parent a17fa6e
commit c45bb32
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -27,7 +27,6 @@ jobs:
       - name: Update coverall
         if: ${{ success() }}
         uses: coverallsapp/github-action@master
-        continue-on-error: true  # 暂时改动
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
 

diff --git a/src/component/legendCategory.ts b/src/component/legendCategory.ts
@@ -170,6 +170,13 @@ function inferLegendShape(
   return { width, height };
 }
 
+function filterEmptyIds(legendStyle) {
+  return {
+    ...legendStyle,
+    data: legendStyle?.data.filter((item) => item.id !== ''),
+  };
+}
+
 /**
  * Guide Component for ordinal color scale.
  */
@@ -211,8 +218,9 @@ export const LegendCategory: GCC<LegendCategoryOptions> = (options) => {
 
     const { legendCategory: legendTheme = {} } = theme;
 
+    // Filter out the data items with empty string IDs in the wordCloud's data before generating the legend.
     const categoryStyle = adaptor(
-      Object.assign({}, legendTheme, legendStyle, style),
+      Object.assign({}, legendTheme, filterEmptyIds(legendStyle), style),
     );
 
     const layoutWrapper = new LegendCategoryLayout({