From 72126893976ec8b7452f368bfd3fa7b39cf166e4 Mon Sep 17 00:00:00 2001
From: Antonio Ojea <aojea@google.com>
Date: Mon, 10 Jun 2024 18:21:57 +0000
Subject: [PATCH] fix readiness for kindnet controller

---
 cmd/kindnet-controller/main.go | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/cmd/kindnet-controller/main.go b/cmd/kindnet-controller/main.go
index 0aa1a2bc..439a0e45 100644
--- a/cmd/kindnet-controller/main.go
+++ b/cmd/kindnet-controller/main.go
@@ -215,10 +215,8 @@ func main() {
 				func() error { return createOrUpdateDaemonset(ctx, clientset, ds) })
 			if err != nil {
 				klog.Infof("error trying to update daemonset: %v", err)
-				ready.Store(false)
 				return
 			}
-			ready.Store(true)
 		},
 		UpdateFunc: func(old, new interface{}) {
 			oldCfg := old.(*v1alpha1.Configuration)
@@ -234,10 +232,8 @@ func main() {
 				func() error { return createOrUpdateDaemonset(ctx, clientset, ds) })
 			if err != nil {
 				klog.Infof("error trying to update daemonset: %v", err)
-				ready.Store(false)
 				return
 			}
-			ready.Store(true)
 		},
 		DeleteFunc: func(obj interface{}) {
 			err := clientset.AppsV1().DaemonSets("kube-system").Delete(ctx, dsKindnetd, metav1.DeleteOptions{})
@@ -252,13 +248,14 @@ func main() {
 	if ok := cache.WaitForCacheSync(ctx.Done(), configInfomer.Informer().HasSynced); !ok {
 		klog.Fatalf("caches not synced waiting for Kindnet Configuration")
 	}
+	klog.Infof("kindnet-controller correctly started")
+	ready.Store(true)
 
 	err = waitForDaemonset(ctx, clientset)
 	if err != nil {
 		panic(err.Error())
 	}
-	ready.Store(true)
-	klog.Infof("kindnetd correctly started")
+	klog.Infof("kindnetd daemonset correctly started")
 
 	select {
 	case <-signalCh: