Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Set Task Instance Note #43755

Closed
2 tasks done
omkar-foss opened this issue Nov 6, 2024 · 1 comment
Closed
2 tasks done

AIP-84 Set Task Instance Note #43755

omkar-foss opened this issue Nov 6, 2024 · 1 comment
Labels
area:API Airflow's REST/HTTP API kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@omkar-foss
Copy link
Collaborator

Description

Currently the Set Task Instance Note public endpoint is at api_connexion/endpoints/task_instance_endpoint.py under set_task_instance_note. We need to migrate it to the api_fastapi/views/public/task_instances.py under a set_task_instance_note or similar.

Features and functionality of the endpoint will remain unchanged.

Use case/motivation

AIP-84 cWiki Link: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-84+UI+REST+API

Related issues

Related to: #42370

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@omkar-foss omkar-foss added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Nov 6, 2024
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Nov 6, 2024
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Nov 6, 2024

This endpoint does not need to be migrated, in the same way as we are doing for the DagRun, the update of the task instance note should be part of the PATCH task instance. (improved/broader PATCH instance).

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

2 participants