Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-72: Allow retrieving Assets via API Server & Task Context #45717

Closed
kaxil opened this issue Jan 16, 2025 · 2 comments · Fixed by #45960
Closed

AIP-72: Allow retrieving Assets via API Server & Task Context #45717

kaxil opened this issue Jan 16, 2025 · 2 comments · Fixed by #45960
Assignees
@Lee-W
Labels
area:API Airflow's REST/HTTP API area:core area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK area:task-sdk
Milestone
Airflow 3.0.0

Comments

@kaxil
Copy link
Member

kaxil commented Jan 16, 2025

To support outlet_events & inlet_events in Context dict within the Task SDK, we will need an endpoint on the API Server which we can fetch when outlet_events & inlet_events are accessed.

airflow/airflow/models/taskinstance.py

Line 1024 in a63b652

"inlet_events": InletEventsAccessors(task.inlets, session=session),

airflow/airflow/models/taskinstance.py

Line 1019 in a63b652

"outlet_events": OutletEventAccessors(),

@kaxil kaxil self-assigned this Jan 16, 2025
@kaxil kaxil added area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK area:task-sdk labels Jan 16, 2025
@dosubot dosubot bot added area:API Airflow's REST/HTTP API area:core labels Jan 16, 2025
kaxil added a commit to astronomer/airflow that referenced this issue Jan 17, 2025
@kaxil
AIP-72: Add support for outlet_events in Task Context
943ecd7 
part of apache#45717

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
@kaxil kaxil mentioned this issue Jan 17, 2025
Merged
kaxil added a commit to astronomer/airflow that referenced this issue Jan 17, 2025
@kaxil
AIP-72: Add support for outlet_events in Task Context
2c40265 
part of apache#45717

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
@kaxil kaxil added this to the Airflow 3.0.0 milestone Jan 17, 2025
kaxil added a commit to astronomer/airflow that referenced this issue Jan 17, 2025
@kaxil
AIP-72: Add support for outlet_events in Task Context
8c04b05 
part of apache#45717

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
kaxil added a commit that referenced this issue Jan 17, 2025
@kaxil
AIP-72: Add support for outlet_events in Task Context (#45727)
418b701 
part of #45717 and #45752

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
@kaxil
Copy link
Member Author

kaxil commented Jan 22, 2025 •
edited
Loading

I have done the OutletEventAccessors in this PR, could either of you do InletEventsAccessors @Lee-W @uranusjr ?

Will help spread the knowledge about Task SDK too.

@kaxil kaxil assigned Lee-W and uranusjr and unassigned kaxil Jan 22, 2025
@Lee-W
Copy link
Member

Lee-W commented Jan 23, 2025

Draft PR #45960 (still super early stage)

dauinh pushed a commit to dauinh/airflow that referenced this issue Jan 24, 2025
@kaxil @dauinh
AIP-72: Add support for outlet_events in Task Context (apache#45727)
981985d 
part of apache#45717 and apache#45752

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this issue Jan 30, 2025
@kaxil @got686-yandex
AIP-72: Add support for outlet_events in Task Context (apache#45727)
430cb64 
part of apache#45717 and apache#45752

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
niklasr22 pushed a commit to niklasr22/airflow that referenced this issue Feb 8, 2025
@kaxil @niklasr22
AIP-72: Add support for outlet_events in Task Context (apache#45727)
6fedb18 
part of apache#45717 and apache#45752

This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
@Lee-W Lee-W mentioned this issue Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lee-W Lee-W

Labels
area:API Airflow's REST/HTTP API area:core area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK area:task-sdk
Projects
AIP-72 - Task Execution Interface and SDK
Status: Done
Milestone
Airflow 3.0.0
Development

Successfully merging a pull request may close this issue.

feat(task_sdk): add support for inlet_events in Task Context astronomer/airflow
3 participants
@uranusjr @Lee-W @kaxil