From 07de55c45ccfa649cce9edc513d4a56edf721ba4 Mon Sep 17 00:00:00 2001 From: david dali susanibar arce Date: Tue, 29 Aug 2023 10:48:47 -0500 Subject: [PATCH] fix: code review --- java/source/data.rst | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/java/source/data.rst b/java/source/data.rst index 9da5fe49..68c754bf 100644 --- a/java/source/data.rst +++ b/java/source/data.rst @@ -43,21 +43,19 @@ is mutated and used to concatenate the added values. IntVector initialValues = new IntVector("initialValues", allocator); IntVector toAppend = new IntVector("toAppend", allocator); ) { - initialValues.allocateNew(2); - initialValues.set(0, 1); - initialValues.set(1, 2); - initialValues.setValueCount(2); - System.out.println("Initial IntVector: " + initialValues); - toAppend.allocateNew(4); - toAppend.set(1, 4); - toAppend.set(3, 6); - toAppend.setValueCount(4); - System.out.println("IntVector to Append: " + toAppend); - VectorAppender appenderUtil = new VectorAppender(initialValues); - ValueVector resultOfVectorsAppended = toAppend.accept(appenderUtil, null); - System.out.println("IntVector Result: " + resultOfVectorsAppended); - System.out.println("Initial IntVector mutated: " + - (initialValues.hashCode()==resultOfVectorsAppended.hashCode())) ; + initialValues.allocateNew(2); + initialValues.set(0, 1); + initialValues.set(1, 2); + initialValues.setValueCount(2); + System.out.println("Initial IntVector: " + initialValues); + toAppend.allocateNew(4); + toAppend.set(1, 4); + toAppend.set(3, 6); + toAppend.setValueCount(4); + System.out.println("IntVector to Append: " + toAppend); + VectorAppender appenderUtil = new VectorAppender(initialValues); + toAppend.accept(appenderUtil, null); + System.out.println("IntVector Result: " + initialValues); } .. testoutput:: @@ -65,7 +63,6 @@ is mutated and used to concatenate the added values. Initial IntVector: [1, 2] IntVector to Append: [null, 4, null, 6] IntVector Result: [1, 2, null, 4, null, 6] - Initial IntVector mutated: true Compare Vectors for Field Equality ==================================