Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Compute] "Scatter" vector functions #44393

Open
zanmato1984 opened this issue Oct 13, 2024 · 0 comments
Open

[C++][Compute] "Scatter" vector functions #44393

zanmato1984 opened this issue Oct 13, 2024 · 0 comments

Comments

@zanmato1984
Copy link
Collaborator

Describe the enhancement requested

We discussed the solution for #41094 , the conclusion is that the "special form" is the way. Comment #41094 (comment) gives a thorough description of how special forms work.

Here I summarize a bit: a special form "mask-ably" evaluates some of its subexpressions based on some masks obtained from its other subexpressions. For example consider if cond then expr1 else expr2, the result of cond is the mask, which controls which rows goes to expr1 and which goes to expr2. Another example is logical and/or, each of its subexpressions is part of the mask to evaluate the rest subexpressions (boolean short-circuit).

One way to implement special forms is that every expression selectively executes its kernel by respecting a selection vector (which rows this kernel should execute on) or a equally boolean mask. But unfortunately this isn't practical because we can't afford to change every (scalar) compute functions to support selection vector/mask all at once. So we must take an adaptive way, allowing functions to be selection vector/mask agnostic. To do so, a special form should 1) takes rows specific to each branch; 2) invoke the function of each branch on each group of these rows; 3) combine the results of all the branches by scattering each row to its original position in the input.

So far we have vector function filter/take to do 1), but there isn't a handy utility to do 3).

Component(s)

C++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant