Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more icons for components #950

Open
davsclaus opened this issue Oct 22, 2023 · 8 comments
Open

Use more icons for components #950

davsclaus opened this issue Oct 22, 2023 · 8 comments
Labels
designer Karavan Designer good first issue Good for newcomers

Comments

@davsclaus
Copy link
Contributor

We can reuse the icons we have for kamelets for some of the components

  • salesforce
  • couchbase
  • and so forth
Screenshot 2023-10-22 at 15 44 26
@davsclaus davsclaus added good first issue Good for newcomers designer Karavan Designer labels Oct 22, 2023
@dewarthim
Copy link

I would like to work on this.

@davsclaus
Copy link
Contributor Author

Thanks you can browse the current components in the knowledge space tab in karavan space
https://karavan.space/

And then find components that can be updated with a new icon. We need a svg icon file for that, which you can then find and report here.

@mgubaidullin can then add those icons, or tell how you can do it, so you can send it as PR

@dewarthim
Copy link

Surely will do!

@mgubaidullin
Copy link
Contributor

Do not forget to check icon license to be compliant with Apache 2.0

@dewarthim
Copy link

Okay

@dewarthim
Copy link

I tried to build the web application, without making changes according to these steps
image

I'm getting this error

image

Anything that I might have missed?

@davsclaus
Copy link
Contributor Author

Can you try to put the code in a path that does not have any spaces from the root

@mgubaidullin
Copy link
Contributor

You could use

cd karavan-designer
npm run start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
designer Karavan Designer good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants