Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify logic in nth_value function #14063

Open
alamb opened this issue Jan 9, 2025 · 2 comments
Open

Clarify logic in nth_value function #14063

alamb opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Jan 9, 2025

          took me a while to figure out what's happening here; maybe instead check slice.nulls() explicitly and return None if it doesn't exist (i.e. there's no nulls)?

also the pre-existing short-circuiting might be useful in cases where the nulls() index exists but valid_indices() truly is empty (i.e. the array is completely nulls)?

Originally posted by @Blizzara in #14042 (comment)

@alamb
Copy link
Contributor Author

alamb commented Jan 9, 2025

I think this is a good initial issue for someone

@zjregee
Copy link
Member

zjregee commented Jan 10, 2025

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants