Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to trigger the extended test suite from a PR #14319

Open
alamb opened this issue Jan 27, 2025 · 3 comments · May be fixed by #14331
Open

Add a way to trigger the extended test suite from a PR #14319

alamb opened this issue Jan 27, 2025 · 3 comments · May be fixed by #14331
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 27, 2025

Is your feature request related to a problem or challenge?

There is a great extended test suite that runs on each PR to main, https://github.com/apache/datafusion/blob/main/.github/workflows/extended.yml

It doesn't run on PRs but does run on every commit to main as doing so consumes a significant amount of CI builder time and the jobs rarely fail. An example run is here: https://github.com/apache/datafusion/actions/runs/12987371654/job/36216118679

Sometimes there are PRs (such as #13681 from @Rachelint ) where it would be really nice to verify that the extended suite still passes before we merge the PR to main

Describe the solution you'd like

I would like some way to trigger the extended test suite from a PR

Describe alternatives you've considered

Maybe we could follow the model of take: https://github.com/apache/datafusion/blob/main/.github/workflows/take.yml

Described in
https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets

So maybe we could make it so if someone added a comment like

test extended

To the PR the extended tests would also trigger

Additional context

No response

@Omega359
Copy link
Contributor

This post might be useful for providing feedback on the status of the extended action being run.

@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2025

Posting a note to the PR saying "extended test suite ran {success_or_failure} on this PR" would be very cool too

@buraksenn
Copy link
Contributor

buraksenn commented Jan 27, 2025

I've opened #14331 for this to try make it work. I've no previous experience in GitHub Actions so maybe I'm very off or did it in an unoptimized way. Thus, opened it as a draft PR, will try to make it work and test if it is okay. Otherwise, I can close and let someone else work on that

I've tested and put the results in testing section. After #14345 is merged, I can get the changes and it will be ready to merge imo. cc @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants