From 8a4294210dbc0b60499670f4a7f54891db2018fd Mon Sep 17 00:00:00 2001 From: zhangdong Date: Wed, 5 Mar 2025 17:58:31 +0800 Subject: [PATCH] [opt](mtmv) metadata cache of external table no longer be refreshed before run async mv task (#48172) Problem Summary: before this PR, external catalog metadata will be sync when refresh async mv that based on external table. after this PR, remove sync metadata action, but the data in async mv still consistent with query in Doris on external table. metadata cache of external table no longer be refreshed before run async mv task --- .../doris/datasource/hive/HMSExternalTable.java | 2 -- .../suites/mtmv_p0/test_hive_refresh_mtmv.groovy | 12 ++++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java index d07f0502d10d78..fda8fbf35c63d0 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java +++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java @@ -1027,8 +1027,6 @@ public boolean isPartitionedTable() { @Override public void beforeMTMVRefresh(MTMV mtmv) throws DdlException { - Env.getCurrentEnv().getRefreshManager() - .refreshTable(getCatalog().getName(), getDbName(), getName(), true); } public HoodieTableMetaClient getHudiClient() { diff --git a/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy b/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy index 75ec61a518b060..f2cfae8c3e92ba 100644 --- a/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy +++ b/regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy @@ -104,6 +104,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke // hive data change logger.info("hive sql: " + insert_str) hive_docker """ ${insert_str} """ + sql """ + REFRESH catalog ${catalog_name} + """ sql """ REFRESH MATERIALIZED VIEW ${mvName} auto """ @@ -117,6 +120,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke """ logger.info("hive sql: " + add_partition2021_str) hive_docker """ ${add_partition2021_str} """ + sql """ + REFRESH catalog ${catalog_name} + """ sql """ REFRESH MATERIALIZED VIEW ${mvName} auto """ @@ -133,6 +139,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke """ logger.info("hive sql: " + drop_partition2021_str) hive_docker """ ${drop_partition2021_str} """ + sql """ + REFRESH catalog ${catalog_name} + """ sql """ REFRESH MATERIALIZED VIEW ${mvName} auto """ @@ -148,6 +157,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke """ logger.info("hive sql: " + rename_column_str) hive_docker """ ${rename_column_str} """ + sql """ + REFRESH catalog ${catalog_name} + """ sql """ REFRESH MATERIALIZED VIEW ${mvName} complete """