From 24455152820c73f3ba189e097eac4585e5ff01e5 Mon Sep 17 00:00:00 2001
From: AlbericByte <albericliu8@gmail.com>
Date: Fri, 8 Dec 2023 15:41:34 -0800
Subject: [PATCH 1/2] fix rat and checkstyle issue

---
 codestyle/checkstyle-suppressions.xml | 36 ++++++++++++++++++++++-----
 pom.xml                               |  7 +++++-
 2 files changed, 36 insertions(+), 7 deletions(-)

diff --git a/codestyle/checkstyle-suppressions.xml b/codestyle/checkstyle-suppressions.xml
index 01868d73f34f..c817af6ec211 100644
--- a/codestyle/checkstyle-suppressions.xml
+++ b/codestyle/checkstyle-suppressions.xml
@@ -29,23 +29,50 @@
   <!-- Code copied from TestNG to apply a bugfix -->
   <suppress checks="AvoidStaticImport" files="[\\/]org[\\/]testng[\\/]" />
 
+  <suppress checks="LocalFinalVariableName" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="SingleSpaceSeparator" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="LocalVariableName" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="AvoidStaticImport" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="ImportOrder" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="RedundantImport" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="UnusedImports" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="EmptyStatement" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="Regexp" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="WhitespaceAfter" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="ModifierOrder" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="RedundantModifier" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="OneStatementPerLine" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="RightCurly" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="MethodName" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="NeedBraces" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="WhitespaceAround" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="Header" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="EmptyLineSeparator" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="LeftCurly" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="Indentation" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks="ConstantName" files="[\\/]target[\\/]generated-sources[\\/]" />
+
   <suppress checks="Header" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="NeedBraces" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="UnusedImports" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="AvoidStarImport" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="FileTabCharacter" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-
+  <suppress checks="ConstantName" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="WhitespaceAfter" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="WhitespaceAround" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="ParenPad" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="SingleSpaceSeparator" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="NoWhitespaceBefore" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="NoWhitespaceAfter" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-
   <suppress checks="LeftCurly" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="RightCurly" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-
   <suppress checks="Indentation" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+  <suppress checks="ModifierOrder" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+  <suppress checks="RedundantImport" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+  <suppress checks="OneStatementPerLine" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+  <suppress checks="ImportOrder" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+  <suppress checks="EmptyLineSeparator" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+
   <suppress checks="Indentation" files="ProtoTestEventWrapper.java" />
   <suppress checks="Regexp" id="argumentLineBreaking" files="ProtoTestEventWrapper.java" />
   <suppress checks="[a-zA-Z0-9]*" files="ProtoTestEventWrapper.java" />
@@ -56,7 +83,6 @@
   <suppress checks="ConstantName" files="Author" />
   <suppress checks="ConstantName" files="Book" />
 
-  <suppress checks="OneStatementPerLine" files="[\\/]target[\\/]generated-test-sources[\\/]" />
 
   <!-- extendedset is a fork of Alessandro Colantonio's CONCISE (COmpressed 'N' Composable Integer SEt) repository
        and licensed to ASF under a CLA is not true. -->
@@ -67,7 +93,5 @@
   <!-- See https://github.com/checkstyle/checkstyle/issues/5510 and the ImportOrder definition in checkstyle.xml -->
   <suppress checks="ImportOrder" message="^'java\..*'.*" />
 
-  <suppress checks="ImportOrder" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="EmptyLineSeparator" files="[\\/]target[\\/]generated-test-sources[\\/]" />
   <suppress checks="AvoidStaticImport" files="[\\/]src[\\/](test)[\\/]"/>
 </suppressions>
diff --git a/pom.xml b/pom.xml
index 9640cd48d147..dc1ef5aa2559 100644
--- a/pom.xml
+++ b/pom.xml
@@ -2108,9 +2108,14 @@
                                 <exclude>**/test/resources/**/*</exclude> <!-- test data for "old" ITs. -->
                                 <exclude>**/docker/client_tls/*</exclude> <!-- generated files for "old" ITs. -->
                                 <exclude>resources/data/**/*</exclude> <!-- test data for "new" ITs. -->
-                                <exclude>**/derby.log</exclude>
                                 <exclude>**/jvm.config</exclude>
                                 <exclude>**/*.avsc</exclude>
+                                <exclude>**/*.png</exclude>
+                                <exclude>**/*.log</exclude>
+                                <exclude>**/*.jpg</exclude>
+                                <exclude>**/*.gif</exclude>
+                                <exclude>examples/quickstart/protobuf/metrics.desc</exclude>
+                                <exclude>examples/var/sv/.lock</exclude>
                                 <exclude>**/*.iml</exclude>
                                 <exclude>**/*.json</exclude>
                                 <exclude>**/*.parq</exclude>

From a637ec6944da89da31d4fe26d05b074a9889198d Mon Sep 17 00:00:00 2001
From: AlbericByte <albericliu8@gmail.com>
Date: Tue, 12 Dec 2023 11:10:39 -0800
Subject: [PATCH 2/2] remove all checks for generated-sources and
 generated-test-sources

---
 codestyle/checkstyle-suppressions.xml | 47 ++-------------------------
 1 file changed, 3 insertions(+), 44 deletions(-)

diff --git a/codestyle/checkstyle-suppressions.xml b/codestyle/checkstyle-suppressions.xml
index c817af6ec211..a19500bd09fe 100644
--- a/codestyle/checkstyle-suppressions.xml
+++ b/codestyle/checkstyle-suppressions.xml
@@ -24,54 +24,13 @@
     "https://checkstyle.org/dtds/suppressions_1_2.dtd">
 
 <suppressions>
-  <!-- See http://checkstyle.sourceforge.net/config_filters.html#SuppressionFilter for examples -->
+  <!-- See https://checkstyle.org/filters/suppressionfilter.html for examples -->
 
   <!-- Code copied from TestNG to apply a bugfix -->
   <suppress checks="AvoidStaticImport" files="[\\/]org[\\/]testng[\\/]" />
 
-  <suppress checks="LocalFinalVariableName" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="SingleSpaceSeparator" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="LocalVariableName" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="AvoidStaticImport" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="ImportOrder" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="RedundantImport" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="UnusedImports" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="EmptyStatement" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="Regexp" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="WhitespaceAfter" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="ModifierOrder" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="RedundantModifier" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="OneStatementPerLine" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="RightCurly" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="MethodName" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="NeedBraces" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="WhitespaceAround" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="Header" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="EmptyLineSeparator" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="LeftCurly" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="Indentation" files="[\\/]target[\\/]generated-sources[\\/]" />
-  <suppress checks="ConstantName" files="[\\/]target[\\/]generated-sources[\\/]" />
-
-  <suppress checks="Header" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="NeedBraces" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="UnusedImports" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="AvoidStarImport" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="FileTabCharacter" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="ConstantName" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="WhitespaceAfter" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="WhitespaceAround" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="ParenPad" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="SingleSpaceSeparator" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="NoWhitespaceBefore" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="NoWhitespaceAfter" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="LeftCurly" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="RightCurly" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="Indentation" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="ModifierOrder" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="RedundantImport" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="OneStatementPerLine" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="ImportOrder" files="[\\/]target[\\/]generated-test-sources[\\/]" />
-  <suppress checks="EmptyLineSeparator" files="[\\/]target[\\/]generated-test-sources[\\/]" />
+  <suppress checks=".*" files="[\\/]target[\\/]generated-sources[\\/]" />
+  <suppress checks=".*" files="[\\/]target[\\/]generated-test-sources[\\/]" />
 
   <suppress checks="Indentation" files="ProtoTestEventWrapper.java" />
   <suppress checks="Regexp" id="argumentLineBreaking" files="ProtoTestEventWrapper.java" />