Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Replace static fields as much as possible in AbstractIT to avoid possible problems when running tests parallelly. #4951

Closed
yuqi1129 opened this issue Sep 18, 2024 · 0 comments · Fixed by #4996
Closed

[Improvement] Replace static fields as much as possible in AbstractIT to avoid possible problems when running tests parallelly. #4951

yuqi1129 opened this issue Sep 18, 2024 · 0 comments · Fixed by #4996
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

Currently, many fields in AbstractIT are marked as static, which could be shared between many tests, I suggest we remove the static flag and make them only object-accessible.

How should we improve?

Remove static field as many as we can.
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Sep 18, 2024
@yuqi1129 yuqi1129 mentioned this issue Sep 23, 2024
Merged
yuqi1129 added a commit that referenced this issue Oct 16, 2024
@yuqi1129
[#4951] improvement(test): Reduce fields shares between different IT …
b7f4e34 
…to make AbstractIT more independent. (#4996)

### What changes were proposed in this pull request?

Remove static fields of `AbstractIT` to make it more robust. 

### Why are the changes needed?

To make it more robut.

Fix: #4951

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

The existing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
1 participant
@yuqi1129