Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Add register/link CLI command for Model #5960

Closed
VigneshSK17 opened this issue Dec 24, 2024 · 2 comments · Fixed by #6066
Closed

[Subtask] Add register/link CLI command for Model #5960

VigneshSK17 opened this issue Dec 24, 2024 · 2 comments · Fixed by #6066
Assignees
@Abyss-lord
Labels
subtask Subtasks of umbrella issue

Comments

@VigneshSK17
Copy link
Contributor

Describe the subtask

Part of an initiative to add Model entity support to CLI

Parent issue

#5959
@VigneshSK17 VigneshSK17 added the subtask Subtasks of umbrella issue label Dec 24, 2024
@VigneshSK17
Copy link
Contributor Author

@Abyss-lord

@VigneshSK17 VigneshSK17 mentioned this issue Dec 24, 2024
Closed
4 tasks
@Abyss-lord
Copy link
Contributor

Thank you, @xunliu I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 2, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
1550a38 
1. Add register and link commands to CLI for model.
2. Add two option for model --uri and --alias.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 2, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
74f370e 
add test case.
@Abyss-lord Abyss-lord mentioned this issue Jan 2, 2025
Merged
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
d4ea895 
1. Add register and link commands to CLI for model.
2. Add two option for model --uri and --alias.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
ca34ee5 
add test case.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
6bafa74 
Fix some error.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
93feb7e 
1. Add register and link commands to CLI for model.
2. Add two option for model --uri and --alias.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
ce05d1b 
add test case.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
a0fe9a2 
Fix some error.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
5eeec9a 
1. Add register and link commands to CLI for model.
2. Add two option for model --uri and --alias.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
04a9339 
Fix some error.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 3, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for model
30ed52b 
Fix some error.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 4, 2025
@Abyss-lord
[apache#5960] fix(CLI): Add register and link commands to CLI for mod…
d27dda0 
…el (apache#6066)

Add register and link commands to CLI for model
- register a model：`model create`
- link a model：`model update <—uri uri> [--alias aliaA aliaB]`

meantime, add two options
- `—uri` ：The URI of the model version artifact.
- `—alias` ：The aliases of the model version.

The documentation will be updated after apache#6047 merge and I will create a
new issue.

Fix: apache#5960

NO

```bash
gcli model create -m demo_metalake --name Hive_catalog.default.model
gcli model create -m demo_metalake --name Hive_catalog.default.model --comment comment
gcli model create -m demo_metalake --name Hive_catalog.default.model --properties key1=val1 key2=val2
gcli model create -m demo_metalake --name Hive_catalog.default.model --properties key1=val1 klinkey2=val2 --comment comment
```

```bash
gcli model update -m demo_metalake --name Hive_catalog.default.model --uri file:///tmp/file
gcli model update -m demo_metalake --name Hive_catalog.default.model --uri file:///tmp/file  --alias aliasA aliasB
gcli model update -m demo_metalake --name Hive_catalog.default.model --uri file:///tmp/file  --alias aliasA aliasB --comment comment --properties key1=val1 key2=val2
gcli model update -m demo_metalake --name Hive_catalog.default.model
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#5960] fix(CLI): Add register and link commands to CLI for model Abyss-lord/gravitino
2 participants
@VigneshSK17 @Abyss-lord