Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when building workflow with openapi spec with multipart content #3723

Open
gabriel-farache opened this issue Oct 14, 2024 · 6 comments · May be fixed by #3743
Open

Error when building workflow with openapi spec with multipart content #3723

gabriel-farache opened this issue Oct 14, 2024 · 6 comments · May be fixed by #3743
Assignees

Comments

@gabriel-farache
Copy link
Contributor

Describe the bug

With 1.34.0 when building I have the following error:

[ERROR] /home/kogito/serverless-workflow-project/target/generated-sources/open-api-stream/org/kie/kogito/openapi/movekube/api/WorkspaceInputsApi.java:[61,60] package org.jboss.resteasy.annotations.providers.multipart does not exist

See enclosed the openapi spec file
move2kube.zip

Expected behavior

No issue when building the workflow

Actual behavior

Error

How to Reproduce?

  1. Create a workflow
  2. Use the enclosed spec or any spec with multipart and/or application/x-www-form-urlencoded content
  3. Build the workflow using OSl 1.34 (registry.redhat.io/openshift-serverless-1/logic-swf-builder-rhel8@sha256:9a4093e195bec163c609381e3c0ceeec55f6e229c6a1def6f362517886faea71)
  4. See the error

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Kogito version or git rev (or at least Quarkus version if you are using Kogito via Quarkus platform BOM)

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@fjtirado
Copy link
Contributor

fjtirado commented Oct 16, 2024

This is a dependency issue which is fixed by manually adding io.quarkus:quarkus-resteasy-multipart dependency.
We need to discuss if we should add this automatically in the quarkus extension or not.

@gabriel-farache
Copy link
Contributor Author

I'm good with that too as long as it is well documented.
Is there, somewhere in your website/doc, a list of all available extensions that can/could/should be used with a description?

@fjtirado
Copy link
Contributor

fjtirado commented Oct 17, 2024

@gabriel-farache We are checking if the dependency is small enough to be automatically added in the quarkiverse extension, or, if it is not, provide a better error message indicating what the user has to do to fix the issue

@ricardozanini
Copy link
Member

@fjtirado @gabriel-farache this is already in the doc: https://docs.quarkiverse.io/quarkus-openapi-generator/dev/client.html#sending-multipart-formdata

So I assume we are still on RESTeasy Classic, @fjtirado?

@gabriel-farache
Copy link
Contributor Author

@ricardozanini It's not in your doc, it's in the openapi generator doc, which is the tool you are using.
I mean, the dependency was removed in the sontaflow builder project hence causing issue to end-user.

As an end-user I may not be aware of all the technicalities and tools you are using behind the hood that's why I was suggesting to have a page in your doc stating which dependencies could be added, and even give advices, like: "you want to use multipart content-type in your api spec, make sure to include this dependency and check other available at https://..."
Because if an end-user, not familiar with quarkus or how everything is built has en error about multipart not supported, if there is no place in your doc (so the product they are using) helping them to sort things out, it may be time consuming for them :)

@ricardozanini
Copy link
Member

ricardozanini commented Oct 17, 2024

It was just a reminder to Javi. We will surely add it to our docs or directly on our side.

mcruzdev pushed a commit to mcruzdev/incubator-kie-kogito-runtimes that referenced this issue Oct 21, 2024
@mcruzdev mcruzdev linked a pull request Oct 21, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants