diff --git a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java index 4933e50506769..014d28acdb991 100644 --- a/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java +++ b/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java @@ -16775,7 +16775,7 @@ fooTopicName, new TopicMetadata(fooTopicId, fooTopicName, 6))) acls.put(fooTopicName, AuthorizationResult.ALLOWED); acls.put(barTopicName, AuthorizationResult.DENIED); when(authorizer.authorize(any(), any())).thenAnswer(invocation -> { - List actions = invocation.getArgument(1, List.class); + List actions = invocation.getArgument(1); return actions.stream() .map(action -> acls.getOrDefault(action.resourcePattern().name(), AuthorizationResult.DENIED)) .collect(Collectors.toList()); diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java index ab37fa6c9d367..f67236eca6ef7 100644 --- a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java +++ b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java @@ -65,12 +65,13 @@ import java.util.Properties; import static java.util.Arrays.asList; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.hamcrest.Matchers.is; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; import static org.mockito.Mockito.mock; @ExtendWith(MockitoExtension.class) @@ -352,12 +353,10 @@ public void testStateStoreLazyEval() { final String topic1 = "topic1"; final String topic2 = "topic2"; - final KTableImpl table1 = - (KTableImpl) builder.table(topic1, consumed); + final var table1 = builder.table(topic1, consumed); builder.table(topic2, consumed); - final KTableImpl table1Mapped = - (KTableImpl) table1.mapValues(s -> Integer.valueOf(s)); + final var table1Mapped = table1.mapValues(s -> Integer.valueOf(s)); table1Mapped.filter((key, value) -> (value % 2) == 0); try (final TopologyTestDriver driver = new TopologyTestDriver(builder.build(), props)) { @@ -371,15 +370,11 @@ public void testStateStore() { final String topic1 = "topic1"; final String topic2 = "topic2"; - final KTableImpl table1 = - (KTableImpl) builder.table(topic1, consumed); - final KTableImpl table2 = - (KTableImpl) builder.table(topic2, consumed); + final var table1 = builder.table(topic1, consumed); + final var table2 = builder.table(topic2, consumed); - final KTableImpl table1Mapped = - (KTableImpl) table1.mapValues(s -> Integer.valueOf(s)); - final KTableImpl table1MappedFiltered = - (KTableImpl) table1Mapped.filter((key, value) -> (value % 2) == 0); + final var table1Mapped = table1.mapValues(s -> Integer.valueOf(s)); + final var table1MappedFiltered = table1Mapped.filter((key, value) -> (value % 2) == 0); table2.join(table1MappedFiltered, (v1, v2) -> v1 + v2); try (final TopologyTestDriver driver = new TopologyTestDriver(builder.build(), props)) { @@ -391,24 +386,20 @@ public void testStateStore() { public void shouldNotEnableSendingOldValuesIfNotMaterializedAlreadyAndNotForcedToMaterialize() { final StreamsBuilder builder = new StreamsBuilder(); - final KTableImpl table = - (KTableImpl) builder.table("topic1", consumed); + final var kTable = assertInstanceOf(KTableImpl.class, builder.table("topic1", consumed)); + kTable.enableSendingOldValues(false); - table.enableSendingOldValues(false); - - assertThat(table.sendingOldValueEnabled(), is(false)); + assertFalse(kTable.sendingOldValueEnabled()); } @Test public void shouldEnableSendingOldValuesIfNotMaterializedAlreadyButForcedToMaterialize() { final StreamsBuilder builder = new StreamsBuilder(); - final KTableImpl table = - (KTableImpl) builder.table("topic1", consumed); - - table.enableSendingOldValues(true); + final var kTable = assertInstanceOf(KTableImpl.class, builder.table("topic1", consumed)); + kTable.enableSendingOldValues(true); - assertThat(table.sendingOldValueEnabled(), is(true)); + assertTrue(kTable.sendingOldValueEnabled()); } private void assertTopologyContainsProcessor(final Topology topology, final String processorName) { @@ -429,8 +420,7 @@ public void shouldCreateSourceAndSinkNodesForRepartitioningTopic() throws Except final String topic1 = "topic1"; final String storeName1 = "storeName1"; - final KTableImpl table1 = - (KTableImpl) builder.table( + final var table1 = builder.table( topic1, consumed, Materialized.>as(storeName1) @@ -587,19 +577,16 @@ public void shouldThrowNullPointerOnTransformValuesWithKeyWhenTransformerSupplie assertThrows(NullPointerException.class, () -> table.transformValues(null)); } - @SuppressWarnings("unchecked") @Test public void shouldThrowNullPointerOnTransformValuesWithKeyWhenMaterializedIsNull() { - final ValueTransformerWithKeySupplier valueTransformerSupplier = - mock(ValueTransformerWithKeySupplier.class); + final ValueTransformerWithKeySupplier valueTransformerSupplier = mock(); assertThrows(NullPointerException.class, () -> table.transformValues(valueTransformerSupplier, (Materialized>) null)); } - @SuppressWarnings("unchecked") + @Test public void shouldThrowNullPointerOnTransformValuesWithKeyWhenStoreNamesNull() { - final ValueTransformerWithKeySupplier valueTransformerSupplier = - mock(ValueTransformerWithKeySupplier.class); + final ValueTransformerWithKeySupplier valueTransformerSupplier = mock(); assertThrows(NullPointerException.class, () -> table.transformValues(valueTransformerSupplier, (String[]) null)); } }