Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDigest: use rocksdb iterator for centroids iteration. #2789

Open
2 tasks done
Tracked by #2558
LindaSummer opened this issue Feb 13, 2025 · 1 comment
Open
2 tasks done
Tracked by #2558

TDigest: use rocksdb iterator for centroids iteration. #2789

LindaSummer opened this issue Feb 13, 2025 · 1 comment
Assignees
Labels
enhancement type enhancement

Comments

@LindaSummer
Copy link
Contributor

LindaSummer commented Feb 13, 2025

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

Related Issue

#2558

In TDigest implementation #2741 , we use DummyCentroids to achieve a simple iteration and it should be refactored to rocksdb native iterator as designed.

#2741 (comment)

Solution

  • Implement a RocksdbCentroids and replace the DummyCentroids.
  • Add more unit tests for encoding, decoding and algorithm.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@LindaSummer
Copy link
Contributor Author

LindaSummer commented Feb 26, 2025

Hi Team,

I'm working on this issue now. 😊

I will create a new centroid iterator with rocksdb iterator directly.

I will add more unit tests and create some benchmark for quantile.

Best Regards,
Edward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

No branches or pull requests

1 participant