Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When implementing IComparable, you should also override ==, !=, <, <=, >, and >= #683

Closed
2 tasks
nikcio opened this issue Oct 15, 2022 · 0 comments · Fixed by #1056
Closed
2 tasks

When implementing IComparable, you should also override ==, !=, <, <=, >, and >= #683

nikcio opened this issue Oct 15, 2022 · 0 comments · Fixed by #1056
Assignees
@paulirwin
Labels
hacktoberfest-accepted is:enhancement New feature or request pri:low up-for-grabs This issue is open to be worked on by anyone
Milestone
4.8.0-beta00018

Comments

@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022 •
edited
Loading

Mentioned in #648

Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1210&id=apache_lucenenet

  • Public classes - If the class is public, we should definitely implement these.
  • Non-public classes - If not public, it probably doesn't matter. But we should do a review just in case.
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone is:enhancement New feature or request hacktoberfest-accepted labels Oct 15, 2022
@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Oct 28, 2024
@paulirwin paulirwin self-assigned this Nov 21, 2024
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Dec 4, 2024
@paulirwin
Add operator overrides for IComparable types, apache#683
3e55bba
@paulirwin paulirwin mentioned this issue Dec 4, 2024
Merged
4 tasks
paulirwin added a commit to paulirwin/lucene.net that referenced this issue Dec 12, 2024
@paulirwin
Add operator overrides for IComparable types, apache#683
6a45ecf
paulirwin added a commit that referenced this issue Dec 15, 2024
@paulirwin
Add operator overrides for public IComparable types, #683 (#1056)
3d489a6 
* Add operator overrides for IComparable types, #683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulirwin paulirwin

Labels
hacktoberfest-accepted is:enhancement New feature or request pri:low up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
4.8.0-beta00018
Development

Successfully merging a pull request may close this issue.

Add operator overrides for public IComparable types, #683 paulirwin/lucene.net
3 participants
@NightOwl888 @paulirwin @nikcio