-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: Add Support unit tests #920
Labels
is:task
A chore to be done
pri:normal
testability
up-for-grabs
This issue is open to be worked on by anyone
Milestone
Comments
@paulirwin - Perhaps eliminating |
NightOwl888
added
up-for-grabs
This issue is open to be worked on by anyone
testability
pri:normal
labels
Mar 10, 2024
NightOwl888
added a commit
to NightOwl888/lucenenet
that referenced
this issue
Mar 10, 2024
…a ref struct to eliminate the heap allocation. Converted TestControlledRealTimeReopenThread.TestStraightForwardDemonstration() to test using ReferenceContext<T> to verify functionality. See apache#920.
NightOwl888
added a commit
that referenced
this issue
Mar 10, 2024
…a ref struct to eliminate the heap allocation. Converted TestControlledRealTimeReopenThread.TestStraightForwardDemonstration() to test using ReferenceContext<T> to verify functionality. See #920.
4 tasks
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 11, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 11, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 11, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 11, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 11, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 11, 2025
paulirwin
added a commit
to paulirwin/lucene.net
that referenced
this issue
Jan 12, 2025
paulirwin
added a commit
that referenced
this issue
Jan 12, 2025
* Add unit tests for IndexableFieldExtensions, #920 * Add unit test for ByteArrayOutputStream, #920 * Add unit tests for CastTo, #920 * Add unit tests for ListExtensions, #920 * Add unit test for AssemblyUtils, #920 * Add unit tests for DictionaryExtensions, #920 * Fix TestByteArrayOutputStream on .NET FX, #920
This was referenced Jan 21, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
is:task
A chore to be done
pri:normal
testability
up-for-grabs
This issue is open to be worked on by anyone
Is there an existing issue for this?
Task description
This is a meta-issue that should be broken out into separate issues.
From #914 via @NightOwl888:
I also noticed we don't have tests for the following types in the Support folder:
IndexableFieldExtensions
(Add some Support unit tests, #920 #1093)ByteArrayOutputStream
- Patch to provideToString()
output forMemoryStream
. (Add some Support unit tests, #920 #1093)ReferenceContext<T>
- We added this to make it possible to use a using block instead ofAcquire()
with a try finally aroundRelease()
. We should convert this to a ref struct, so it doesn't cause a heap allocation to use. Ref structs cannot implementIDisposable
, but the compiler allows a using block ifDispose()
exists. Note thatReferenceManagerExtensions
can be tested along with it.CastTo<T>
(Add some Support unit tests, #920 #1093)ListExtensions
(Add some Support unit tests, #920 #1093)(This was removed instead in BREAKING: Remove SystemConsole class, #920, #936 #1113)SystemConsole
- .NET should have some tests we can use for this.AssemblyUtils
(Add some Support unit tests, #920 #1093)ConcurrentDictionaryWrapper<TKey, TValue>
- This is no longer in use, we can probably eliminate it along with the DictionaryExtensions.AsConcurrent() extension method. It may come in handy for a future version of Lucene, though.DictionaryExtensions
(Add some Support unit tests, #920 #1093)The text was updated successfully, but these errors were encountered: