From 008ba360f3148e4ee0c91477c09da24c89e02963 Mon Sep 17 00:00:00 2001 From: omkarshitole Date: Thu, 2 Jan 2025 19:25:54 +0530 Subject: [PATCH] remove redundant commented code --- .../rewrite/context/SQLRewriteContext.java | 31 +++++++------------ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/infra/rewrite/src/main/java/org/apache/shardingsphere/infra/rewrite/context/SQLRewriteContext.java b/infra/rewrite/src/main/java/org/apache/shardingsphere/infra/rewrite/context/SQLRewriteContext.java index a415711d8cbaf..95e68fd476db1 100644 --- a/infra/rewrite/src/main/java/org/apache/shardingsphere/infra/rewrite/context/SQLRewriteContext.java +++ b/infra/rewrite/src/main/java/org/apache/shardingsphere/infra/rewrite/context/SQLRewriteContext.java @@ -69,26 +69,17 @@ public SQLRewriteContext(final ShardingSphereDatabase database, final QueryConte if (!queryContext.getHintValueContext().isSkipSQLRewrite()) { addSQLTokenGenerators(new DefaultTokenGeneratorBuilder(sqlStatementContext).getSQLTokenGenerators()); } - List genericParams = - (sqlStatementContext.getSqlStatement() instanceof PostgreSQLInsertStatement) - ? ((InsertStatementContext) sqlStatementContext).getOnConflictKeyUpdateParameters() - : ((InsertStatementContext) sqlStatementContext).getOnDuplicateKeyUpdateParameters(); - parameterBuilder = containsInsertValues(sqlStatementContext) - ? new GroupedParameterBuilder(((InsertStatementContext) sqlStatementContext).getGroupedParameters(), - genericParams) - : new StandardParameterBuilder(parameters); - - // if (sqlStatementContext.getSqlStatement() instanceof PostgreSQLInsertStatement) { - // parameterBuilder = containsInsertValues(sqlStatementContext) - // ? new GroupedParameterBuilder(((InsertStatementContext) sqlStatementContext).getGroupedParameters(), - // ((InsertStatementContext) sqlStatementContext).getOnConflictKeyUpdateParameters()) - // : new StandardParameterBuilder(parameters); - // } else { - // parameterBuilder = containsInsertValues(sqlStatementContext) - // ? new GroupedParameterBuilder(((InsertStatementContext) sqlStatementContext).getGroupedParameters(), - // ((InsertStatementContext) sqlStatementContext).getOnDuplicateKeyUpdateParameters()) - // : new StandardParameterBuilder(parameters); - // } + if (sqlStatementContext.getSqlStatement() instanceof PostgreSQLInsertStatement) { + parameterBuilder = containsInsertValues(sqlStatementContext) + ? new GroupedParameterBuilder(((InsertStatementContext) sqlStatementContext).getGroupedParameters(), + ((InsertStatementContext) sqlStatementContext).getOnConflictKeyUpdateParameters()) + : new StandardParameterBuilder(parameters); + } else{ + parameterBuilder = containsInsertValues(sqlStatementContext) + ? new GroupedParameterBuilder(((InsertStatementContext) sqlStatementContext).getGroupedParameters(), + ((InsertStatementContext) sqlStatementContext).getOnDuplicateKeyUpdateParameters()) + : new StandardParameterBuilder(parameters); + } } private boolean containsInsertValues(final SQLStatementContext sqlStatementContext) {