From d1e6c60e359a3666a8dcbb858dbb16d8072d140f Mon Sep 17 00:00:00 2001 From: zhangliang Date: Sun, 29 Dec 2024 20:38:45 +0800 Subject: [PATCH] Refactor ProcessListChangedSubscriber --- .../subscriber/type/ProcessListChangedSubscriber.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/dispatch/subscriber/type/ProcessListChangedSubscriber.java b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/dispatch/subscriber/type/ProcessListChangedSubscriber.java index 4e9c64cd2c84e..d4e9c65924b56 100644 --- a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/dispatch/subscriber/type/ProcessListChangedSubscriber.java +++ b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/event/dispatch/subscriber/type/ProcessListChangedSubscriber.java @@ -42,14 +42,14 @@ */ public final class ProcessListChangedSubscriber implements DispatchEventSubscriber { - private final ContextManager contextManager; + private final String instanceMetaDataId; private final PersistRepository repository; private final YamlProcessListSwapper swapper; public ProcessListChangedSubscriber(final ContextManager contextManager) { - this.contextManager = contextManager; + instanceMetaDataId = contextManager.getComputeNodeInstanceContext().getInstance().getMetaData().getId(); repository = contextManager.getPersistServiceFacade().getRepository(); swapper = new YamlProcessListSwapper(); } @@ -61,7 +61,7 @@ public ProcessListChangedSubscriber(final ContextManager contextManager) { */ @Subscribe public void reportLocalProcesses(final ReportLocalProcessesEvent event) { - if (!event.getInstanceId().equals(contextManager.getComputeNodeInstanceContext().getInstance().getMetaData().getId())) { + if (!event.getInstanceId().equals(instanceMetaDataId)) { return; } Collection processes = ProcessRegistry.getInstance().listAll(); @@ -89,7 +89,7 @@ public synchronized void completeToReportLocalProcesses(final ReportLocalProcess */ @Subscribe public synchronized void killLocalProcess(final KillLocalProcessEvent event) throws SQLException { - if (!event.getInstanceId().equals(contextManager.getComputeNodeInstanceContext().getInstance().getMetaData().getId())) { + if (!event.getInstanceId().equals(instanceMetaDataId)) { return; } Process process = ProcessRegistry.getInstance().get(event.getProcessId());