Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update firebird insert statement to support returning #33977

Closed
TedCraft opened this issue Dec 9, 2024 · 0 comments · Fixed by #34047
Closed

Update firebird insert statement to support returning #33977

TedCraft opened this issue Dec 9, 2024 · 0 comments · Fixed by #34047
Labels
db: Firebird in: SQL parse type: enhancement
Milestone
5.5.2

Comments

@TedCraft
Copy link
Contributor

TedCraft commented Dec 9, 2024 •
edited
Loading

Feature Request

For English only, other languages will not be accepted.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

Related to #33699.

Describe the feature you would like.

Currently firebird parser does not support RETURNING in insert statements, but prepareStatement with Statement.RETURN_GENERATED_KEYS automatically adds RETURN to the given SQL.

Docs: https://firebirdsql.org/refdocs/langrefupd21-insert.html.

Example SQL:

INSERT INTO t_order (user_id, order_type, address_id, status) VALUES (?, ?, ?, ?)
RETURNING *
@terrymanu terrymanu added this to the 5.5.2 milestone Dec 9, 2024
makssent added a commit to red-soft-ru/shardingsphere that referenced this issue Dec 12, 2024
@makssent
Update firebird insert statement to support returning (apache#33977)
405b4d4
@makssent makssent mentioned this issue Dec 13, 2024
Merged
7 tasks
terrymanu pushed a commit that referenced this issue Dec 13, 2024
@makssent @TedCraft
Added support returning for some firebird requests (#34047)
147b225 
* Update firebird insert statement to support returning (#33977)

* Refactor RETURNING statement to use projections

* Update firebird update statement to support returning

* Update firebird delete statement to support returning

---------

Co-authored-by: TedCraft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
db: Firebird in: SQL parse type: enhancement
Projects
None yet
Milestone
5.5.2
Development

Successfully merging a pull request may close this issue.

Added support returning for some firebird requests red-soft-ru/shardingsphere
2 participants
@terrymanu @TedCraft