Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Range popover doesn't show up correctly on more filters bar when scrollbar activated #32208

Open
2 of 3 tasks
alexandrusoare opened this issue Feb 10, 2025 · 3 comments
Open
2 of 3 tasks
Labels
dashboard:filtersets Related to the filtersets of the Dashboard

Comments

@alexandrusoare
Copy link
Contributor

Bug description

  1. Go to any dashboard
  2. Set the filter bar horizontally, and add filters until the popover from "more filters" button gets a scrollbar
  3. Click on one filter that is a time-range filter within the popover of "more filters"

It was also mentioned in this PR #31973

Screenshots/recordings

410834869-823b3734-c936-4e8a-b78f-a47b131c1560.mp4

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the dashboard:filtersets Related to the filtersets of the Dashboard label Feb 10, 2025
Copy link

dosubot bot commented Feb 10, 2025

Hey @alexandrusoare! I'm here to help you with any bugs, questions, or contributions you have for Superset. Let's tackle this together!

The issue you're experiencing with the time-range popover not displaying correctly when the scrollbar is activated in the "more filters" bar might be related to known issues with popover rendering and positioning in Superset. There have been previous bug fixes addressing similar problems, such as incorrect positioning of tooltips on scroll [1].

To address this, you might want to check if the ControlPopover component is handling the dynamic content and positioning correctly. The calculatePlacement function within this component is responsible for determining the popover's placement based on the visibility ratio of the trigger element within the viewport [2].

Additionally, ensure that the CSS styles for the scrollbar are correctly applied, as they can affect the popover's appearance. The styles for the scrollbar in the popover are defined in the CSS, which includes settings for the scrollbar's width, thumb, and track [3].

If the issue persists, reviewing the changes in the mentioned PR #31973 might provide further insights or potential fixes related to this behavior.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@rusackas
Copy link
Member

@sadpandajoe @michael-s-molina should we add this to the 5.0 issues board?

@michael-s-molina
Copy link
Member

@rusackas You can check if the issue is reproducible using #32146. If yes, then we can add it to the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:filtersets Related to the filtersets of the Dashboard
Projects
None yet
Development

No branches or pull requests

3 participants