Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed quests #130

Open
apaleslimghost opened this issue Jan 17, 2019 · 3 comments
Open

failed quests #130

apaleslimghost opened this issue Jan 17, 2019 · 3 comments
Labels
⛓️ data a feature that has implications for the database schema ⚒️ feature

Comments

@apaleslimghost
Copy link
Owner

quests and objectives currently have a boolean completed field. this should become an enumy thing of (incomplete|complete|failed). have the splash say the right thing. would require support in edit-card.js's SchemaFields for <select>s. state machine would probably be best implicit in the quest control thing. maybe a different sound than ka-shing for failed quests?

@apaleslimghost apaleslimghost added ⚒️ feature ⛓️ data a feature that has implications for the database schema labels Jan 17, 2019
@apaleslimghost
Copy link
Owner Author

(@rowanmanning you mentioned you might want to do this?)

@rowanmanning
Copy link
Collaborator

Yeah I'm interested in doing this.

I'd also quite like for the quest UI in the dashboard admin to have more labelling if that's something you're open to? Possibly a drop-down? Mostly there have been a few times where I've accidentally changed the state of a quest and then had to recreate it.

Another question: is there scope for "current" or "active" to be one of the states? Or is this worked out in a completely different way?

@apaleslimghost
Copy link
Owner Author

so there's no real concept of "active" quest/objective, apart from the currentQuest campaign session variable, which only governs which quest to show at hte top of the list. i was looking at sorting the quest/objective list by most recent history which seems complex. do you have a suggestion for how it could work?

in the #59 world there would be no separate quest editing on the dashboard widget, and with #126 you'd be able to revert the history (note that you can current fix a quest state by doing it through the cards view not the dashboard). you can fix the ux of the quests block if you like though 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛓️ data a feature that has implications for the database schema ⚒️ feature
Projects
None yet
Development

No branches or pull requests

2 participants