Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR CI checks fail the lock file is not up to date with the latest changes in composer.json #416

Closed
Angatar opened this issue Dec 5, 2023 · 1 comment

Comments

@Angatar
Copy link

Angatar commented Dec 5, 2023

My PR (#415) only includes the relevant code directly related to the new feature added however the CI checks fail and according to the CI logs it seems the composer.lock was not updated for the required symfony/phpunit-bridge package used for running the tests:
Here is a part of the CI Build&Test logs returned:

Created project in /home/runner/work/schema-generator/schema-generator/vendor/bin/.phpunit/phpunit-9-0
composer.json has been updated
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.

  • Required package "symfony/phpunit-bridge" is not present in the lock file.

Has it to be fixed in the CI pipeline with a composer update additional step or do I need to include the updated composer.json/composer.lock files in my PR?

Originally posted by @Angatar in #415 (comment)

@Angatar
Copy link
Author

Angatar commented Dec 6, 2023

Thanks for #417, it has updated the composer.json and composer.lock files, which had for side effect to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant