Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows creation of proposals that will revert once passed #265

Open
bbenligiray opened this issue Nov 23, 2021 · 0 comments
Open

Allows creation of proposals that will revert once passed #265

bbenligiray opened this issue Nov 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@bbenligiray
Copy link
Member

bbenligiray commented Nov 23, 2021

We can check if the proposal to be created will execute by using a VoidSigner that assumes the address of the respective agent the proposal is being made for. We do a .callStatic() call to check if it reverts, and display a warning message at proposal creation time if it does.

Note that this checks if the proposal would execute if it passed now, which may create some confusion. For example, say the agent has no funds. Knowing that it will be funded by the time my proposal passes, I attempt to create a proposal to transfer funds from it. Since the agent doesn't have these funds yet, the static call will revert and the dashboard will display a warning telling me that the proposal looks like it's going to revert. Here, I need to use my judgement and create the proposal anyway.

In general, I'm in favor of people creating proposals exactly and carefully. Hand-holding to this degree may result in people being even more careless about creating proposals or voting on them. Nah, this feature is needed.

@Siegrift Siegrift added the bug Something isn't working label Nov 24, 2021
@bbenligiray bbenligiray added enhancement New feature or request and removed bug Something isn't working labels Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants