Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin @percy/cli from v1.18.0 #436

Open
mcoetzee opened this issue Jan 9, 2024 · 0 comments
Open

Unpin @percy/cli from v1.18.0 #436

mcoetzee opened this issue Jan 9, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@mcoetzee
Copy link
Collaborator

mcoetzee commented Jan 9, 2024

Taking snapshots with Percy fails in our Cypress tests from v1.19 (which is why it was pinned to v1.18.0)

TypeError: Cannot read properties of null (reading 'sheet')
      at styleSheetFromNode (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at serializeCSSOM (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at serializeElements (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at Object.serializeDOM (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at Context.eval (webpack://api3-dao-dashboard/./node_modules/@percy/cypress/index.js:59:0)

Shadow DOM serialisation seems to be the main thing introduced with v1.19 https://github.com/percy/cli/releases/tag/v1.19.2

It might be related to the web3modal because it uses shadow DOM.

@mcoetzee mcoetzee added the dependencies Pull requests that update a dependency file label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant