Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand DAO Dashboard - Unstake banner #486

Closed
Anboias opened this issue Nov 14, 2024 · 3 comments · Fixed by #507
Closed

Rebrand DAO Dashboard - Unstake banner #486

Anboias opened this issue Nov 14, 2024 · 3 comments · Fixed by #507

Comments

@Anboias
Copy link
Collaborator

Anboias commented Nov 14, 2024

Requirements

Update Unstake Banner from the Staking page. Designs

Image

@peterjurco peterjurco self-assigned this Nov 28, 2024
@peterjurco peterjurco linked a pull request Dec 2, 2024 that will close this issue
@PrenaamD
Copy link
Collaborator

PrenaamD commented Dec 3, 2024

@peterjurco
"Unstake within {days} and {hours}" present in the design is missing from the implementation.
Not sure if it also requires a logic change.

@peterjurco
Copy link
Collaborator

@PrenaamD Yeah, this isn't in the implementation. I don't know why there should be a time limit for unstaking, I don't see any logic for this implemented or even hinted in the repo.

@PrenaamD
Copy link
Collaborator

PrenaamD commented Dec 3, 2024

Yes. I don't know if there is a staking time limit. I'll report it to the Design team. If needed, this can be revisited in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants