-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate-verify CI job retries provider initialization redundantly #409
Comments
This is only an issue when the RPC is down, and hopefully ethers takes care of it at some point |
Isn't this draining the CI credits though 🤔 |
@hiletmis questioned this as well, does it not time out at 50 seconds anyway? |
I have tried creating an invalid provider. |
That is the client side timeout only - it doesn't stop the underlying thing from running (that's why Airseeker needs to have this patched).
The question is whether the verification script finishes after the timeout or waits for the underlying calls to finish (which I've not checkd) |
Verification script finishes, does not wait for calls to finish. I have also set timeout to |
Related
https://github.com/api3dao/contracts/actions/runs/13544228288/job/37854340468#step:8:11
https://github.com/api3dao/airseeker/blob/86a078339855494aa233bd6525fbfaa5e0767749/src/update-feeds-loops/contracts.ts#L14
ethers-io/ethers.js#4377 (comment)
The text was updated successfully, but these errors were encountered: