Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-verify CI job retries provider initialization redundantly #409

Open
bbenligiray opened this issue Feb 27, 2025 · 6 comments
Open
Labels
wontfix This will not be worked on

Comments

@bbenligiray bbenligiray added the wontfix This will not be worked on label Feb 27, 2025
@bbenligiray
Copy link
Member Author

This is only an issue when the RPC is down, and hopefully ethers takes care of it at some point

@Siegrift
Copy link
Contributor

Isn't this draining the CI credits though 🤔

@bbenligiray
Copy link
Member Author

@hiletmis questioned this as well, does it not time out at 50 seconds anyway?

@hiletmis
Copy link
Contributor

hiletmis commented Feb 28, 2025

I have tried creating an invalid provider. @api3/promise-utils timeout works as expected. It timeouts.

@Siegrift
Copy link
Contributor

That is the client side timeout only - it doesn't stop the underlying thing from running (that's why Airseeker needs to have this patched).

timeout works as expected. It timeouts.

The question is whether the verification script finishes after the timeout or waits for the underlying calls to finish (which I've not checkd)

@hiletmis
Copy link
Contributor

The question is whether the verification script finishes after the timeout or waits for the underlying calls to finish (which I've not checkd)

Verification script finishes, does not wait for calls to finish. I have also set timeout to 10ms to see if it works for valid providers and it finished right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants