-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Create a common component out of Entity Item and Editable Entity Name components in ADS #38853
Labels
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Task
A simple Todo
Comments
2 tasks
ankitakinger
added a commit
that referenced
this issue
Jan 31, 2025
Loading
Loading status checks…
… it to one (#38885) ## Description Extracting out common logic between two ADS components to move it to one. Fixes [#38853](#38853) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13067939918> > Commit: dd17cf1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13067939918&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 31 Jan 2025 08:26:34 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced `EditableEntityName` component with new properties: - Added `canEdit` to control editability - Added `isFixedWidth` for width behavior - Added `size` option for component sizing - Introduced `canEdit` property in `EditableDismissibleTab` for better editing control - Simplified icon rendering logic across components - **Bug Fixes** - Updated name validation to require a minimum of 1 character - Improved scrolling behavior in `DataSidePane` - **Style** - Refined layout and styling for editable components - Updated component alignment and spacing - Removed unnecessary styled components for cleaner design <!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot
pushed a commit
to Zeral-Zhang/appsmith
that referenced
this issue
Feb 7, 2025
… it to one (appsmithorg#38885) ## Description Extracting out common logic between two ADS components to move it to one. Fixes [appsmithorg#38853](appsmithorg#38853) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13067939918> > Commit: dd17cf1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13067939918&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 31 Jan 2025 08:26:34 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced `EditableEntityName` component with new properties: - Added `canEdit` to control editability - Added `isFixedWidth` for width behavior - Added `size` option for component sizing - Introduced `canEdit` property in `EditableDismissibleTab` for better editing control - Simplified icon rendering logic across components - **Bug Fixes** - Updated name validation to require a minimum of 1 character - Improved scrolling behavior in `DataSidePane` - **Style** - Refined layout and styling for editable components - Updated component alignment and spacing - Removed unnecessary styled components for cleaner design <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Task
A simple Todo
SubTasks
The text was updated successfully, but these errors were encountered: