Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Git Modularisation] Toast messages not coming up when Default branch and Protected Branch settings are updated #38862

Closed
1 task done
kamakshibhat-appsmith opened this issue Jan 28, 2025 · 0 comments · Fixed by #39140
Assignees
Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Release

Comments

@kamakshibhat-appsmith
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Toast messages not coming up when Default branch and Protected Branch settings are updated

Steps To Reproduce

Expected :

Image

Current :
No toast

Public Sample App

No response

Environment

Release

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

Cloud/SelfHosted

@kamakshibhat-appsmith kamakshibhat-appsmith added Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Release labels Jan 28, 2025
@kamakshibhat-appsmith kamakshibhat-appsmith added the Git Platform Issues related to the git & the app platform label Jan 28, 2025
@github-actions github-actions bot added Packages & Git Pod All issues belonging to Packages and Git and removed Git Platform Issues related to the git & the app platform labels Jan 28, 2025
@appsmith-bot appsmith-bot added the QA Needs QA attention label Feb 10, 2025
@github-actions github-actions bot removed the Packages & Git Pod All issues belonging to Packages and Git label Feb 10, 2025
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 12, 2025
## Description
Fixes issue with missing success toast related to git

Fixes appsmithorg#38872
Fixes appsmithorg#38862

## Automation
/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13216997415>
> Commit: 95ccaed
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13216997415&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Sat, 08 Feb 2025 17:43:52 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- New Features  
- Discard operations now display clear, contextual success messages to
enhance user feedback.
- Toast notifications have been added for pull actions and protected
branch updates, providing real-time confirmation of successful
operations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants