Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.8 reached end of life (October 2024) #264

Closed
loreloc opened this issue Sep 10, 2024 · 7 comments · Fixed by #274
Closed

Python 3.8 reached end of life (October 2024) #264

loreloc opened this issue Sep 10, 2024 · 7 comments · Fixed by #274
Assignees
Labels
good first issue Good for newcomers low-priority Low priority issues repository Related to managing the repository

Comments

@loreloc
Copy link
Member

loreloc commented Sep 10, 2024

As suggested by @lkct, upgrade the whole repository to Python 3.9 (EOL Oct 2025) or Python 3.10 (EOL Oct 2026). I guess many things about typing have changed.
https://devguide.python.org/versions/

@loreloc loreloc added the repository Related to managing the repository label Sep 10, 2024
@loreloc loreloc added this to the Cirkit 0.1.0 milestone Sep 10, 2024
@loreloc loreloc changed the title Python 3.8 reached end of life Python 3.8 reached end of life (October) Sep 10, 2024
@loreloc loreloc changed the title Python 3.8 reached end of life (October) Python 3.8 reached end of life (October 2024) Sep 10, 2024
@loreloc loreloc added the good first issue Good for newcomers label Sep 18, 2024
@lkct
Copy link
Member

lkct commented Sep 25, 2024

@loreloc loreloc pinned this issue Sep 27, 2024
@loreloc
Copy link
Member Author

loreloc commented Sep 27, 2024

Perhaps use this just one time to upgrade all the type hints from Python 3.8 to 3.9.
https://adamj.eu/tech/2021/05/21/python-type-hints-how-to-upgrade-syntax-with-pyupgrade/
https://github.com/asottile/pyupgrade

@loreloc loreloc self-assigned this Sep 27, 2024
@lkct
Copy link
Member

lkct commented Sep 27, 2024

Just to note that I have left some # FURURE comments in the repo. Those with the corresponding version can be cleaned every time we move to the next Python version.

@loreloc
Copy link
Member Author

loreloc commented Sep 30, 2024

We decided to move directly to Python 3.10. Motivation: 3.10 is the default python version in the oldest Ubuntu LTS version. Also, https://colab.google/articles/py3.10

@loreloc loreloc unpinned this issue Sep 30, 2024
@lkct
Copy link
Member

lkct commented Sep 30, 2024

we might need to double-check, e.g. (main as of today)

RGNodeMetadata: TypeAlias = dict[str, Union[int, float, str, bool]]

re-opening with lo-pri

EDIT: seems pylint can catch this #244

@lkct lkct reopened this Sep 30, 2024
@lkct lkct added the low-priority Low priority issues label Sep 30, 2024
@loreloc
Copy link
Member Author

loreloc commented Oct 9, 2024

That one is now fixed in main, but I do not know if there is an automatic way to check for this kind of issues without reading the whole pylint output.

@loreloc
Copy link
Member Author

loreloc commented Oct 14, 2024

I am going to close this, since there is no reliable and automatic way to check that we are always using the latest python features.

@loreloc loreloc closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low-priority Low priority issues repository Related to managing the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants