Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-sha256 hashes during resolution in pip_lock rule #22

Open
apt-itude opened this issue Jun 11, 2019 · 0 comments
Open

Handle non-sha256 hashes during resolution in pip_lock rule #22

apt-itude opened this issue Jun 11, 2019 · 0 comments
Labels
done Completed in a branch but not yet merged into master
Milestone
v1.0.0

Comments

@apt-itude
Copy link
Owner

The requirement source resolved by pip may have a hash of a different format than sha256, but Bazel repository rules expect a sha256 hash. The lock rule should detect this, calculate a sha256 hash from the wheel file, and use that instead.
@apt-itude apt-itude added this to the v1.0.0 milestone Jun 11, 2019
apt-itude added a commit that referenced this issue Jun 12, 2019
@apt-itude
The resolve module now computes a sha256 sum if the link doesn't alre…
6b0e8a2 
…ady have one

Resolves #22
@apt-itude apt-itude added the done Completed in a branch but not yet merged into master label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done Completed in a branch but not yet merged into master
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@apt-itude