From f772a1704be811d40123dc6ea4a91284a828fb1f Mon Sep 17 00:00:00 2001 From: Igor Date: Fri, 20 Dec 2024 16:43:25 -0800 Subject: [PATCH] adjusting thresholds --- .../src/suites/realistic_environment.rs | 16 ++++++++-------- testsuite/forge-cli/src/suites/ungrouped.rs | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/testsuite/forge-cli/src/suites/realistic_environment.rs b/testsuite/forge-cli/src/suites/realistic_environment.rs index 9e59f4e67177d..f7c15c78ae101 100644 --- a/testsuite/forge-cli/src/suites/realistic_environment.rs +++ b/testsuite/forge-cli/src/suites/realistic_environment.rs @@ -179,7 +179,7 @@ pub(crate) fn realistic_env_fairness_workload_sweep() -> ForgeConfig { ]), criteria: Vec::new(), background_traffic: background_traffic_for_sweep_with_latency( - &[(3.0, 8.0), (3.0, 8.0), (3.0, 4.0)], + &[(2.0, 3.0, 8.0), (0.1, 3.0, 8.0), (0.1, 3.0, 4.0)], false, ), }) @@ -213,14 +213,14 @@ pub(crate) fn realistic_env_graceful_workload_sweep() -> ForgeConfig { criteria: Vec::new(), background_traffic: background_traffic_for_sweep_with_latency( &[ - (4.0, 5.0), - (2.2, 3.0), - (3.5, 5.0), - (4.0, 6.0), - (2.5, 4.0), - (3.5, 5.0), + (0.1, 4.0, 5.0), + (0.1, 2.2, 3.0), + (0.1, 3.5, 5.0), + (0.1, 4.0, 6.0), + (0.1, 2.5, 4.0), + (0.1, 3.5, 5.0), // TODO - p50 and p90 is set to high, until it is calibrated/understood. - (3.0, 10.0), + (0.1, 3.0, 10.0), ], true, ), diff --git a/testsuite/forge-cli/src/suites/ungrouped.rs b/testsuite/forge-cli/src/suites/ungrouped.rs index 31a81f09c5dad..2830e63712dec 100644 --- a/testsuite/forge-cli/src/suites/ungrouped.rs +++ b/testsuite/forge-cli/src/suites/ungrouped.rs @@ -428,16 +428,16 @@ pub fn background_traffic_for_sweep(num_cases: usize) -> Option Option { Some(BackgroundTraffic { traffic: background_emit_request(high_gas_price), - criteria: criteria + criteria: criteria_expired_p50_and_p90 .iter() - .map(|(p50, p90)| { + .map(|(expired, p50, p90)| { SuccessCriteria::new_float(9.5) - .add_max_expired_tps(0.1) + .add_max_expired_tps(*expired) .add_max_failed_submission_tps(0.0) .add_latency_threshold(*p50, LatencyType::P50) .add_latency_threshold(*p90, LatencyType::P90)