Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move embedded C code to a header file #250

Closed
2 tasks
geyslan opened this issue Sep 23, 2022 · 0 comments · Fixed by #257
Closed
2 tasks

Move embedded C code to a header file #250

geyslan opened this issue Sep 23, 2022 · 0 comments · Fixed by #257
Labels
good first issue Good for newcomers

Comments

@geyslan
Copy link
Member

geyslan commented Sep 23, 2022 •
edited
Loading

Since embedded C code is placed as a comment in Go files, we could move into a C header file, enabling the use of tools for automatic formatting and checking following the Tracee way.

This is related to main changes on building - #177.

However, for this, the goals are only:

  • move the C code to a header to be included in the embedded part.
  • format the new header file using clang-format.
@geyslan geyslan added the good first issue Good for newcomers label Sep 23, 2022
@geyslan geyslan mentioned this issue Sep 23, 2022
Open
mozillazg added a commit to mozillazg/libbpfgo that referenced this issue Oct 5, 2022
@mozillazg
Move embedded C code to a header file
2b1521d 
 aquasecurity#250
@mozillazg mozillazg mentioned this issue Oct 5, 2022
Merged
grantseltzer pushed a commit that referenced this issue Oct 7, 2022
@mozillazg
Move embedded C code to a header file (#257)
3c30919 
* Move embedded C code to a header file (Handle #250)

* add fmt-check and fmt-fix make targets for running clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move embedded C code to a header file mozillazg/libbpfgo
1 participant
@geyslan