Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Version Hard-coded in Client #25

Open
sjbodzo opened this issue Feb 26, 2021 · 0 comments
Open

API Version Hard-coded in Client #25

sjbodzo opened this issue Feb 26, 2021 · 0 comments
Assignees

Comments

@sjbodzo
Copy link

sjbodzo commented Feb 26, 2021

The api version used for the various calls in the client package is hard-coded. The version is inconsistent between some of the calls, such as between the firewall rules enforcer orchestration.

Proposal: If the API version should be consistent for all issued calls, pass in a version parameter to the Client struct. If they differ per endpoint due to functionality of the product, pass in versions for for each relevant product functionality to the Client struct.

This will decouple the API version from the provider logic, allowing good defaults and supporting customers in the future who may require calling different API versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants