Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing event translation ids in protobuf #4358

Open
NDStrahilevitz opened this issue Oct 20, 2024 · 0 comments
Open

Missing event translation ids in protobuf #4358

NDStrahilevitz opened this issue Oct 20, 2024 · 0 comments

Comments

@NDStrahilevitz
Copy link
Collaborator

NDStrahilevitz commented Oct 20, 2024

Since we've added the hardcoded gRPC event ids we've added some new events which are not translated.
So in terms of fixing:

  1. Add these events: security_task_rlimit, security_settime, tracee_info (all new events since commit 9356795)

I emphasize again that the hard typing does not allow us dynamisn in adding new events from external sources. At the very least, in order to avoid these errors in the future we need to do either:

  1. add code generation for these relevant sections (not ideal IMO)
  2. remove the golang enum event definitions and only use the externally defined grpc defined IDs (more type style PRs but at least we keep types consistent and reduce the amount of translation points).

@rscampos FYI since you implemented the feature.
@yanivagman FYI for the design concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant