Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse arguments of triggering events #4601

Open
NDStrahilevitz opened this issue Feb 19, 2025 · 2 comments
Open

Parse arguments of triggering events #4601

NDStrahilevitz opened this issue Feb 19, 2025 · 2 comments
Assignees
Milestone

Comments

@NDStrahilevitz
Copy link
Collaborator

NDStrahilevitz commented Feb 19, 2025

Summary

Findings include an argument named "triggeredBy" which encodes a summary of the triggering event in the signature.
Previously, the encoded arguments would be parsed if the parse-arguments flag was enabled. Since (#4544) moving to disabling the flag by default, and moving the parse stage, if enabled, to occur only after the signature stage, the encoded events consequently do not have parsed arguments.

Usecase

Clients may want to receive the arguments:

  1. Entirely parsed in all events
  2. Parsed only in the output events(?) - probably not necessary but could be implemented in addition
  3. Parsed only in the triggering events
  4. Raw in all events

I think this should be configured via the parse-arguments flag. Maybe its time to promote it from option to full subflag in output.

Further, analyze should support this usecase. As such parse-arguments may be relevant for analyze too (this could be resolved in #4425 just as well, so support in analyze depends on the priority of that issue).

@NDStrahilevitz NDStrahilevitz added this to the v0.24.0 milestone Feb 19, 2025
@NDStrahilevitz NDStrahilevitz self-assigned this Feb 19, 2025
@geyslan
Copy link
Member

geyslan commented Feb 19, 2025

I suppose this ties into our earlier discussion at #4563 (comment), even from a broader perspective.

I think this should be configured via the parse-arguments flag. Maybe it's time to promote it from an option to a full subflag in output.

That makes sense to me, given the use case.

@NDStrahilevitz
Copy link
Collaborator Author

It certainly ties in the sense that I forgot to include that this requirement applies to analyze as well!
In that case though it was related to parsing being insufficient in analyze, here this shouldn't be the case as most arguments are not architecture specific (and those which are are already handled in the process stage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants