bug(k8s): scan for k8s v1.31.1 not working

[fl0pp5]

Description

I have a problem with scanning on k8s v1.31.1
Trivy freezes when trying to scan

Research:

Problem:

https://github.com/aquasecurity/trivy-kubernetes/blob/b070991579cacd7634052dee2e250350d6e493e8/pkg/jobs/runnable_job.go#L68
On v1.31.1 condition.Type == batchv1.JobSuccessCriteriaMet but we await batchv1.JobComplete

Solution:

@@ -65,7 +65,7 @@ func (r *runnableJob) Run(ctx context.Context) error {
                                return
                        }
                        switch condition := newJob.Status.Conditions[0]; condition.Type {
-                       case batchv1.JobComplete:
+                       case batchv1.JobComplete, batchv1.JobSuccessCriteriaMet:
                                complete <- nil
                        case batchv1.JobFailed:

Result:

Success scan

Desired Behavior

Success scan

Actual Behavior

2024-10-10T10:52:50+03:00 DEBUG No plugins loaded
2024-10-10T10:52:50+03:00 DEBUG Default config file "file_path=trivy.yaml" not found, using built in values
2024-10-10T10:52:50+03:00 DEBUG Cache dir dir="/root/.cache/trivy"
2024-10-10T10:52:50+03:00 DEBUG Cache dir dir="/root/.cache/trivy"
2024-10-10T10:52:50+03:00 DEBUG Parsed severities severities=[UNKNOWN LOW MEDIUM HIGH CRITICAL]
2024-10-10T10:52:50+03:00 DEBUG Ignore statuses statuses=[]

Reproduction Steps

1. install ALT Linux (or another one distro)
2. install k8s >= 1.31
3. deploy k8s
4. install trivy
5. start trivy for k8s scan

Target

Kubernetes

Scanner

None

Output Format

Table

Mode

Standalone

Debug Output

2024-10-10T10:52:50+03:00	DEBUG	No plugins loaded
2024-10-10T10:52:50+03:00	DEBUG	Default config file "file_path=trivy.yaml" not found, using built in values
2024-10-10T10:52:50+03:00	DEBUG	Cache dir	dir="/root/.cache/trivy"
2024-10-10T10:52:50+03:00	DEBUG	Cache dir	dir="/root/.cache/trivy"
2024-10-10T10:52:50+03:00	DEBUG	Parsed severities	severities=[UNKNOWN LOW MEDIUM HIGH CRITICAL]
2024-10-10T10:52:50+03:00	DEBUG	Ignore statuses	statuses=[]

Operating System

ALT Linux

Version

Version: 0.55.0
Vulnerability DB:
  Version: 2
  UpdatedAt: 2024-10-09 12:25:57.698388082 +0000 UTC
  NextUpdate: 2024-10-10 12:25:57.698387701 +0000 UTC
  DownloadedAt: 2024-10-09 17:12:04.934936122 +0000 UTC
Check Bundle:
  Digest: sha256:ef2d9ad4fce0f933b20a662004d7e55bf200987c180e7f2cd531af631f408bb3
  DownloadedAt: 2024-10-10 07:39:40.997199851 +0000 UTC

Checklist

• Run trivy clean --all
• Read the troubleshooting

[afdesk]

hi @fl0pp5
thanks for the report!

I'll retest Trivy with v1.31.1 where the new type was added.

[afdesk]

@fl0pp5 thanks a lot.
I could reproduce it.
created #7736 to track