Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbom component impovements #5019

Closed
chen-keinan opened this issue Aug 21, 2023 · 2 comments · Fixed by #5058
Closed

kbom component impovements #5019

chen-keinan opened this issue Aug 21, 2023 · 2 comments · Fixed by #5058
Assignees
@chen-keinan
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Milestone
v0.45.0

Comments

@chen-keinan
Copy link
Contributor

chen-keinan commented Aug 21, 2023 •
edited
Loading

in components of type application:
- change component.name to official k8s upstream component
- use component.version
- add actual workload name under aquasecurity:trivy:workloadName
- deprecate aquasecurity:trivy:k8s:component:Name
@chen-keinan chen-keinan added the target/kubernetes Issues relating to kubernetes cluster scanning label Aug 21, 2023
@chen-keinan chen-keinan self-assigned this Aug 21, 2023
@chen-keinan chen-keinan mentioned this issue Aug 21, 2023
Closed
@chen-keinan chen-keinan added this to the v0.46.0 milestone Aug 21, 2023
@chen-keinan
Copy link
Contributor Author

chen-keinan commented Aug 22, 2023 •
edited
Loading

@itaysk maybe we should use aquasecurity:trivy:resource:name instead of aquasecurity:trivy:workload:name to make it more generic, wdyt ?

@chen-keinan chen-keinan added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 22, 2023
@itaysk
Copy link
Contributor

itaysk commented Aug 27, 2023

sure that also works

This was referenced Aug 29, 2023
Merged
Merged
@chen-keinan chen-keinan modified the milestones: v0.46.0, v0.45.0 Aug 30, 2023
@chen-keinan chen-keinan mentioned this issue Aug 30, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chen-keinan chen-keinan

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Projects
Trivy Roadmap
Archived in project
Milestone
v0.45.0
Development

Successfully merging a pull request may close this issue.

feat: improve kbom component name chen-keinan/trivy
2 participants
@itaysk @chen-keinan