Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of .NET *Packages.props files. #5403

Closed
DmitriyLewen opened this issue Oct 19, 2023 Discussed in #5379 · 3 comments · Fixed by #5605
Closed

Add support of .NET *Packages.props files. #5403

DmitriyLewen opened this issue Oct 19, 2023 Discussed in #5379 · 3 comments · Fixed by #5605
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. scan/vulnerability Issues relating to vulnerability scanning

Comments

@DmitriyLewen
Copy link
Contributor

Description

Add support of Directory.Packages.props files.
Also we can parse Packages.props files. These files were used before Directory.Packages.props and use same format - #5379 (reply in thread)

@DmitriyLewen DmitriyLewen added kind/feature Categorizes issue or PR as related to a new feature. scan/vulnerability Issues relating to vulnerability scanning labels Oct 19, 2023
@knqyf263 knqyf263 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 19, 2023
@yuriShafet
Copy link
Contributor

@DmitriyLewen Should I first create a parser in go-dep-parser repo and then when it is merged add in this repo rest of the implementation?

@DmitriyLewen
Copy link
Contributor Author

Should I first create a parser in go-dep-parser repo

You are right.

then when it is merged add in this repo rest of the implementation?

You don't need to wait for the go-dep-parser PR merge. You can create PR for Trivy (add analyzer, docs, tests, etc.) and use go replace with commit from your fork.
This will help ensure that your changes works correctly and as expected.

@yuriShafet
Copy link
Contributor

@DmitriyLewen
PR with parser code:
aquasecurity/go-dep-parser#268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. scan/vulnerability Issues relating to vulnerability scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants