Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty vendor for RPM packages in Amazon Linux #5887

Closed
knqyf263 opened this issue Jan 6, 2024 Discussed in #5869 · 5 comments · Fixed by #5951
Closed

Empty vendor for RPM packages in Amazon Linux #5887

knqyf263 opened this issue Jan 6, 2024 Discussed in #5869 · 5 comments · Fixed by #5951
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@knqyf263
Copy link
Collaborator

knqyf263 commented Jan 6, 2024

Description

The vendor may be empty even in official packages. Since the vendor is used to determine if it is a third package or not, other methods need to be considered. One heuristic that comes to mind easily at present is whether or not the release contains "amzn".

Discussed in #5869

@knqyf263 knqyf263 added the kind/bug Categorizes issue or PR as related to a bug. label Jan 6, 2024
@DmitriyLewen
Copy link
Contributor

@knqyf263 I created #5951
Also I checked some version of curl-minimal and only one version doesn't have Vendor fields:

bash-5.2# yum list curl-minimal --showduplicates
...
curl-minimal.aarch64              8.3.0-1.amzn2023.0.1               amazonlinux
curl-minimal.aarch64              8.3.0-1.amzn2023.0.2               amazonlinux
curl-minimal.aarch64              8.5.0-1.amzn2023.0.1               amazonlinux

bash-5.2# rpm -qi curl-minimal
Name        : curl-minimal
Version     : 8.3.0
Release     : 1.amzn2023.0.1
Architecture: aarch64
Install Date: Tue Jan 16 06:04:09 2024
Group       : Unspecified
Size        : 395875
License     : curl
Signature   : RSA/SHA512, Thu Sep 21 20:36:29 2023, Key ID e951904ad832c631
Source RPM  : curl-8.3.0-1.amzn2023.0.1.src.rpm
Build Date  : Thu Sep 21 19:34:30 2023
Build Host  : ip-10-0-37-69.us-west-2.compute.internal
Packager    : Amazon Linux
Vendor      : Amazon Linux
URL         : https://curl.se/
Summary     : Conservatively configured build of curl for minimal installations

bash-5.2# rpm -qi curl-minimal
Name        : curl-minimal
Version     : 8.3.0
Release     : 1.amzn2023.0.2
Architecture: aarch64
Install Date: Tue Jan 16 07:13:43 2024
Group       : Unspecified
Size        : 395875
License     : curl
Signature   : RSA/SHA512, Tue Oct 10 16:33:12 2023, Key ID e951904ad832c631
Source RPM  : curl-8.3.0-1.amzn2023.0.2.src.rpm
Build Date  : Fri Oct  6 19:21:45 2023
Build Host  : ip-10-0-35-91.us-west-2.compute.internal
URL         : https://curl.se/
Summary     : Conservatively configured build of curl for minimal installations

bash-5.2# rpm -qi curl-minimal
Name        : curl-minimal
Version     : 8.5.0
Release     : 1.amzn2023.0.1
Architecture: aarch64
Install Date: Tue Jan 16 07:14:08 2024
Group       : Unspecified
Size        : 396832
License     : curl
Signature   : RSA/SHA512, Thu Dec 14 17:37:56 2023, Key ID e951904ad832c631
Source RPM  : curl-8.5.0-1.amzn2023.0.1.src.rpm
Build Date  : Thu Dec 14 00:40:29 2023
Build Host  : ip-10-0-37-122.us-west-2.compute.internal
Packager    : Amazon Linux
Vendor      : Amazon Linux
URL         : https://curl.se/
Summary     : Conservatively configured build of curl for minimal installations

It seems bug is only for one version.
@tonaim have you seen other packages with this problem?

@knqyf263 knqyf263 added this to the v0.49.0 milestone Jan 17, 2024
@tonaim
Copy link
Collaborator

tonaim commented Jan 17, 2024

yes, exactly it is happening only with one package. I did not find any other such package .

@DmitriyLewen
Copy link
Contributor

So I think merge #5951 can wait.
If we find similar packages, we will merge this PR.

@knqyf263
Copy link
Collaborator Author

I've already added it to the merge queue😄 Yes, I also think this is Amazon's bug, but our approach with the vendor field is also heuristic. It is good to have various ways to identify official packages.

@tonaim
Copy link
Collaborator

tonaim commented Jan 17, 2024

Thank you @knqyf263 and @DmitriyLewen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants