From 8b33d01d7c1cbf42ec163690579a5d82a62cc502 Mon Sep 17 00:00:00 2001 From: Anthony Mahanna Date: Mon, 22 Apr 2024 16:28:18 -0400 Subject: [PATCH] fix: autoincrement collection --- arango/database.py | 9 +++++---- tests/test_collection.py | 11 +++++++++-- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/arango/database.py b/arango/database.py index ca0895b9..935d4186 100644 --- a/arango/database.py +++ b/arango/database.py @@ -1442,10 +1442,11 @@ def create_collection( :raise arango.exceptions.CollectionCreateError: If create fails. """ key_options: Json = {"type": key_generator, "allowUserKeys": user_keys} - if key_increment is not None: - key_options["increment"] = key_increment - if key_offset is not None: - key_options["offset"] = key_offset + if key_generator == "autoincrement": + if key_increment is not None: + key_options["increment"] = key_increment + if key_offset is not None: + key_options["offset"] = key_offset data: Json = { "name": name, diff --git a/tests/test_collection.py b/tests/test_collection.py index 65860c36..9d85e912 100644 --- a/tests/test_collection.py +++ b/tests/test_collection.py @@ -190,14 +190,21 @@ def test_collection_management(db, bad_db, cluster): } ] + col = db.create_collection( + name=col_name, key_generator="autoincrement", key_increment=9, key_offset=100 + ) + key_options = col.properties()["key_options"] + assert key_options["key_generator"] == "autoincrement" + assert key_options["key_increment"] == 9 + assert key_options["key_offset"] == 100 + db.delete_collection(col_name) + col = db.create_collection( name=col_name, sync=True, system=False, key_generator="traditional", user_keys=False, - key_increment=9, - key_offset=100, edge=True, shard_count=2, shard_fields=["test_attr:"],