From 8b55a6e23307775e4488a5adf17a9f5c187c048f Mon Sep 17 00:00:00 2001 From: Christopher Byrd Date: Thu, 14 Sep 2023 19:25:46 -0700 Subject: [PATCH] updates component dependencies to fail loudly #1300 (#1301) --- arches_for_science/media/js/afs-formats.js | 14 ++++++++------ arches_for_science/media/js/afs-settings.js | 16 ++++++++++------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/arches_for_science/media/js/afs-formats.js b/arches_for_science/media/js/afs-formats.js index d3a0a4b04..91a363150 100644 --- a/arches_for_science/media/js/afs-formats.js +++ b/arches_for_science/media/js/afs-formats.js @@ -3,11 +3,13 @@ define(['utils/load-component-dependencies'], function(loadComponentDependencies return string.replace(/,\s*}*$/, "}"); } - const afsFormatDataHTML = document.querySelector('#afsFormatData'); - const afsFormatData = afsFormatDataHTML.getAttribute('afsFormats'); - const fileRenderers = JSON.parse(removeTrailingCommaFromObject(afsFormatData)); + try { + const afsFormatDataHTML = document.querySelector('#afsFormatData'); + const afsFormatData = afsFormatDataHTML.getAttribute('afsFormats'); + const fileRenderers = JSON.parse(removeTrailingCommaFromObject(afsFormatData)); - // loadComponentDependencies(Object.values(fileRenderers).map(value => value['component'])); - - return fileRenderers; + return fileRenderers; + } catch (error) { + console.error(error); + } }); \ No newline at end of file diff --git a/arches_for_science/media/js/afs-settings.js b/arches_for_science/media/js/afs-settings.js index ec48deef9..27594e2bd 100644 --- a/arches_for_science/media/js/afs-settings.js +++ b/arches_for_science/media/js/afs-settings.js @@ -3,11 +3,15 @@ define([], function() { return string.replace(/,\s*}*$/, "}"); } - const afsSettingsDataHTML = document.querySelector('#projectSettings'); - const cloudStorageText = afsSettingsDataHTML.getAttribute('cloudStorage'); - const cloudStorage = JSON.parse(removeTrailingCommaFromObject(cloudStorageText)); + try { + const afsSettingsDataHTML = document.querySelector('#projectSettings'); + const cloudStorageText = afsSettingsDataHTML.getAttribute('cloudStorage'); + const cloudStorage = JSON.parse(removeTrailingCommaFromObject(cloudStorageText)); - return { - cloudStorage - }; + return { + cloudStorage + }; + } catch (error) { + console.error(error); + } }); \ No newline at end of file