Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisional editors can't add samples #1294

Open
jacobtylerwalls opened this issue Sep 12, 2023 · 3 comments
Open

Provisional editors can't add samples #1294

jacobtylerwalls opened this issue Sep 12, 2023 · 3 comments

Comments

@jacobtylerwalls
Copy link
Member

  1. Give "tester1" access to workflows
  2. Log in as tester1/Test12345!
  3. Attempt sample workflow

Result:

2023-09-12 09:47:42 'This card requires values for the following: Removal from Object_Removed From'
2023-09-12 09:47:42 Traceback (most recent call last):
2023-09-12 09:47:42   File "/web_root/arches-for-science/arches_for_science/views/analysis_area_and_sample_taking.py", line 406, in post
2023-09-12 09:47:42     removed_from_tile = self.save_removed_from_tile(
2023-09-12 09:47:42   File "/web_root/arches-for-science/arches_for_science/views/analysis_area_and_sample_taking.py", line 336, in save_removed_from_tile
2023-09-12 09:47:42     tile.save(transaction_id=transactionid, request=request, index=False)
2023-09-12 09:47:42   File "/usr/local/lib/python3.10/dist-packages/arches/app/models/tile.py", line 409, in save
2023-09-12 09:47:42     self.check_for_missing_nodes()
2023-09-12 09:47:42   File "/usr/local/lib/python3.10/dist-packages/arches/app/models/tile.py", line 318, in check_for_missing_nodes
2023-09-12 09:47:42     raise TileValidationError(message)
2023-09-12 09:47:42 arches.app.models.tile.TileValidationError: 'This card requires values for the following: Removal from Object_Removed From'
2023-09-12 09:47:42 Internal Server Error: /savesamplearea

Found while writing a regression test for #1292

@jacobtylerwalls
Copy link
Member Author

Similar to #81?

@chiatt
Copy link
Member

chiatt commented Sep 18, 2023

There are probably other places in workflows where edits are assumed to be authoritative

@jacobtylerwalls
Copy link
Member Author

We could at least raise a better error on the backend indicating the lack of permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 On hold
Development

No branches or pull requests

2 participants