-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with branches and commits with non-model content #71
Comments
In fact this is not just limited to branches, but any commit that does not contain Archi grafico XML files. |
Comment from @jbsarrodie in orginal thread:
I know, I did the same test.
I might have found another option.... Few knows it, but branch name can contain some non alphabetical characters like slash '/'. So when a user creates a branch, we could (internally) add a known prefix that ends with '/', for example 'Archi/'. Doing so would allow us to filter branches managed by Archi: either 'master' or a branch that starts by 'Archi/'. Of course we could remove the prefix to only show the remaining part in UI. We could even us this to keep track of the "parents" of a branch (ie. the branches it is forked off). For this we would simply add the short name of a branch to the full name of its parent: Imagine we create 'Project_A' off 'master', this would create 'master/Project_A'. If we then create 'Scenario_1' off 'Project_A', this would create 'master/Project_A/Scenario_1'... So all branches managed by Archi would start with 'master', making it easy to filter them. This would have the advantage to allow to show this full path in the Branch view. Of course, this really works only if we never rename a branch, but we already assume this would not happen. |
The test "letstest" repo has an orphan branch called "web" and the "Archisurance" repo has a "gh-pages" branch (not an orphan). These branches contain content not related to the model. So what happens if user switches to this branch:
We probably need to hide these special branches. Note - I don't know how to determine an orphan branch in JGit.
Perhaps when we check if a new commit is required before doing a further action we should have the option to abandon the changes for the commit as well as cancelling?
Originally posted by @Phillipus in #67 (comment)
The text was updated successfully, but these errors were encountered: